Skip to content

Commit

Permalink
Merge pull request #140 from jbampton/fix-word-case-and-remove-whites…
Browse files Browse the repository at this point in the history
…pace

Fix word case and remove whitespace.
  • Loading branch information
alexcjohnson committed Oct 17, 2019
1 parent 61b33f1 commit 7c41d42
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/dash-html-components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- [#110](https://github.com/plotly/dash-html-components/pull/110), [#111](https://github.com/plotly/dash-html-components/pull/111) Improved the property definitions in advance of the Dev Tools property validation.
In particular:
- Boolean properties like `hidden` accept a bool or a case insensitive string with the same name (e.g. `'hidden'` or `'HIDDEN'`)
- Numeric properties like `rows`, `max`, `min` allow a stringified number or a number
- Numeric properties like `rows`, `max`, `min` allow a stringified number or a number

### Added
- Added `formNoValidate` & `inputMode` properties.
Expand Down
4 changes: 2 additions & 2 deletions packages/dash-html-components/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Vanilla HTML components for [Dash][]
$ virtualenv venv
$ venv/bin/activate
```
_Note: venv\Scripts\activate for windows_
_Note: venv\Scripts\activate for Windows_
2. Install Python packages required to build components.
```
Expand Down Expand Up @@ -51,7 +51,7 @@ _Note: This step will have already been done for you when you ran `npm install`_
# Now you're done. For subsequent changes, if you've got `npm run build:watch`
$ python setup.py install

3. Run the dash layout you want to test
3. Run the Dash layout you want to test

# Import dash_html_components to your layout, then run it:
$ python my_dash_layout.py
Expand Down
2 changes: 1 addition & 1 deletion packages/dash-html-components/tests/IntegrationTests.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def run():
s.server_process.start()
time.sleep(0.5)

# Visit the dash page
# Visit the Dash page
s.driver.get('http://localhost:8050')
time.sleep(0.5)

Expand Down
6 changes: 3 additions & 3 deletions packages/dash-html-components/tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ def update_output(*args):
time.sleep(2)
self.wait_for_text_to_equal('#container', '1, 0')
print(timestamp_1.value)
print((time.time() - (24 * 60 * 60)) * 1000)
print((time.time() - (24 * 60 * 60)) * 1000)
self.assertTrue(
timestamp_1.value >
((time.time() - (24 * 60 * 60)) * 1000))
((time.time() - (24 * 60 * 60)) * 1000))
self.assertEqual(timestamp_2.value, -1)
self.assertEqual(call_count.value, 2)
self.snapshot('button-1 click')
Expand All @@ -142,7 +142,7 @@ def update_output(*args):
self.assertEqual(timestamp_1.value, prev_timestamp_1)
self.assertTrue(
timestamp_2.value >
((time.time() - 24 * 60 * 60) * 1000))
((time.time() - 24 * 60 * 60) * 1000))
self.assertEqual(call_count.value, 3)
self.snapshot('button-2 click')
prev_timestamp_2 = timestamp_2.value
Expand Down

0 comments on commit 7c41d42

Please sign in to comment.