Merge pull request #2461 from plotly/fix-2460

Fix pytest make report
plotly · Mar 17, 2023 · 55b7674 · 55b7674
2 parents 43cbf3b + 341000b
commit 55b7674
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 All notable changes to `dash` will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## [UNRELEASED]
+
+## Fixed
+
+- [#2461](https://github.com/plotly/dash/pull/2461) Fix pytest plugin make report when testing not installed, fix [#2420](https://github.com/plotly/dash/issues/2420)
+
 ## [2.9.0] - 2023-03-16
 
 ## Breaking

diff --git a/dash/testing/plugin.py b/dash/testing/plugin.py
@@ -105,10 +105,10 @@ def pytest_addhooks(pluginmanager):
 
 @pytest.hookimpl(tryfirst=True, hookwrapper=True)
 def pytest_runtest_makereport(item, call):  # pylint: disable=unused-argument
-    if not _installed:
-        return
     # execute all other hooks to obtain the report object
     outcome = yield
+    if not _installed:
+        return
     rep = outcome.get_result()
 
     # we only look at actual failing test calls, not setup/teardown