Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Commit

Permalink
Issue 284 - Add source map to NPM and PyPi packages (#285)
Browse files Browse the repository at this point in the history
  • Loading branch information
Marc-Andre-Rivet authored Dec 7, 2018
1 parent e77b090 commit 4f5b940
Show file tree
Hide file tree
Showing 13 changed files with 1,424 additions and 1,418 deletions.
12 changes: 12 additions & 0 deletions .config/tslint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"defaultSeverity": "error",
"extends": "./../tslint.json",

"jsRules": {
"no-console": false
},
"rules": {
"no-console": false
},
"rulesDirectory": []
}
37 changes: 19 additions & 18 deletions .config/webpack/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = (preprocessor = {}, mode = 'development') => {
return {
entry: {
bundle: './src/dash-table/index.ts',
demo: ['./demo/index.js', './demo/index.html'],
demo: ['./demo/index.js', './demo/index.html']
},
mode: mode,
output: {
Expand All @@ -21,18 +21,19 @@ module.exports = (preprocessor = {}, mode = 'development') => {
library: dashLibraryName,
libraryTarget: 'umd'
},
devtool: 'source-map',
externals: {
react: {
commonjs: "react",
commonjs2: "react",
amd: "React",
root: "React"
commonjs: 'react',
commonjs2: 'react',
amd: 'React',
root: 'React'
},
"react-dom": {
commonjs: "react-dom",
commonjs2: "react-dom",
amd: "ReactDOM",
root: "ReactDOM"
'react-dom': {
commonjs: 'react-dom',
commonjs2: 'react-dom',
amd: 'ReactDOM',
root: 'ReactDOM'
},
'plotly.js': 'Plotly'
},
Expand All @@ -58,25 +59,25 @@ module.exports = (preprocessor = {}, mode = 'development') => {
use: [
{ loader: 'style-loader' },
{ loader: 'css-loader' }
],
]
},
{
test: /\.less$/,
use: [
{ loader: 'style-loader' },
{ loader: 'css-loader' },
{ loader: 'less-loader' }
],
},
],
]
}
]
},
resolve: {
alias: {
'cypress': path.resolve('./tests/cypress/src'),
cypress: path.resolve('./tests/cypress/src'),
'dash-table': path.resolve('./src/dash-table'),
'demo': path.resolve('./demo'),
'core': path.resolve('./src/core'),
'tests': path.resolve('./tests')
demo: path.resolve('./demo'),
core: path.resolve('./src/core'),
tests: path.resolve('./tests')
},
extensions: ['.js', '.ts', '.tsx']
}
Expand Down
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [3.1.9-rc1] - 2018-12-03
## [3.1.9] - 2018-12-06
### Added
- Source map [#284](https://github.com/plotly/dash-table/issues/284)
Related Dash issue [#480](https://github.com/plotly/dash/issues/480)
### Changed
- Refactoring in preparation for data types
- Refactoring in preparation for data types [#280](https://github.com/plotly/dash-table/issues/280)

## [3.1.8] - 2018-12-04
### Added
Expand Down
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
include dash_table/bundle.js
include dash_table/bundle.js.map
include dash_table/metadata.json
include dash_table/package-info.json
include README.md
Expand Down
8 changes: 8 additions & 0 deletions dash_table/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@
'https://unpkg.com/dash-table@{}/dash_table/bundle.js'
).format(__version__),
'namespace': package_name
},
{
'relative_package_path': 'bundle.js.map',
'external_url': (
'https://unpkg.com/dash-table@{}/dash_table/bundle.js.map'
).format(__version__),
'namespace': package_name,
'dynamic': True
}
]

Expand Down
5 changes: 2 additions & 3 deletions dash_table/_imports_.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from .DataTable import DataTable


__all__ = [
"DataTable",
]
"DataTable"
]
5 changes: 3 additions & 2 deletions dash_table/bundle.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dash_table/bundle.js.map

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions dash_table/demo.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dash_table/demo.js.map

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions dash_table/package-info.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-table",
"version": "3.1.9-rc1",
"version": "3.1.9",
"description": "Dash table",
"main": "dash_table/bundle.js",
"scripts": {
Expand Down Expand Up @@ -44,14 +44,14 @@
"@babel/preset-react": "^7.0.0",
"@cypress/webpack-preprocessor": "^4.0.2",
"@percy-io/percy-storybook": "^2.1.0",
"@storybook/cli": "^4.0.11",
"@storybook/react": "^4.0.11",
"@storybook/cli": "^4.0.12",
"@storybook/react": "^4.0.12",
"@types/ramda": "^0.25.42",
"@types/react": "^16.7.13",
"@types/react-select": "^1.3.4",
"babel-loader": "^8.0.4",
"core-js": "^2.6.0",
"css-loader": "^1.0.1",
"css-loader": "^2.0.0",
"cypress": "^3.1.3",
"file-loader": "^2.0.0",
"http-server": "^0.11.1",
Expand All @@ -68,15 +68,15 @@
"style-loader": "^0.23.1",
"ts-loader": "^5.3.1",
"tslint": "^5.11.0",
"typescript": "^3.2.1",
"typescript": "^3.2.2",
"wait-on": "^3.2.0",
"webpack": "^4.27.0",
"webpack": "^4.27.1",
"webpack-cli": "^3.1.2",
"webpack-dev-server": "^3.1.10",
"webpack-preprocessor": "^0.1.12"
},
"files": [
"/dash_table/bundle*.js"
"/dash_table/bundle*{.js,.map}"
],
"peerDependencies": {
"react": ">=0.14",
Expand Down
Loading

0 comments on commit 4f5b940

Please sign in to comment.