Dash 1.0 - Update version to 1.0.0a1 #97
Conversation
valentijnnieman
requested review from
chriddyp and
bpostlethwaite
and removed request for
chriddyp
chriddyp
added
the
dash 2.0
|
Is there any way to install this rc release via pip? Or, anything blocking merging it to master for full release? |
|
Hey @nite, you can install with I'm not in a position to comment on the plans for merging, but since this introduces some pretty major changes I think it won't happen imminently. Check this issue for some pretty extensive discussion of the upcoming changes. |
Marc-Andre-Rivet
changed the title
# Conflicts: # CHANGELOG.md # dash_renderer/dash_renderer.dev.js # dash_renderer/dash_renderer.min.js # dash_renderer/version.py # package-lock.json # package.json
Marc-Andre-Rivet
removed
the
dash 2.0
|
@nite @tcbegley Thanks for your patience. The dash-renderer and dash-core-components have both previously been pre-released under 1.0.0rc1, this release will be deleted and replaced with 1.0.0a1. We are doing this in an attempt to better match semantic versioning expectations -- an As 1.0.0a1 < 1.0.0rc1 this may cause some inconvenience and I apologize for that. |
| @@ -51,7 +51,7 @@ class Reloader extends React.Component { | |||
| ) { | |||
| // Look if it was a css file. | |||
| let was_css = false; | |||
| for (let a of reloadRequest.content.files) { | |||
| for (const a of reloadRequest.content.files) { | |||
| @@ -1754,29 +1754,12 @@ def test_update_react_version(self): | |||
| dash_renderer._js_dist_dependencies, | |||
| [{ | |||
| 'external_url': [ | |||
| 'https://unpkg.com/react@15.4.2/dist/react.min.js', | |||
| 'https://unpkg.com/react-dom@15.4.2/dist/react-dom.min.js', | |||
| 'https://unpkg.com/react@16.6.3/umd/react.production.min.js', | |||
There was a problem hiding this comment.
update our local and remote react versions
| _REACT_VERSION_TO_URLS = { | ||
| '15.4.2': { | ||
| '16.6.3': { |
There was a problem hiding this comment.
Bump to 16.x, remove 15.x
| @@ -1,6 +1,6 @@ | |||
| dash_core_components==0.33.0 | |||
| dash_html_components==0.11.0rc5 | |||
| dash==0.32.0 | |||
| dash_html_components==0.13.4 | |||
There was a problem hiding this comment.
There's a fix in html comps for react 16, needs to be present for all tests to pass
There was a problem hiding this comment.
Great!
Going forward how should reviewers ensure / feel confident that these PRs are going to be tested in our internal applications for real world testing?
Is there going to be another PR for release-v1 -> master where we will have a checkbox list after the last commit containing all the apps we need to have tested in?
| dash_html_components==0.11.0rc5 | ||
| dash==0.32.0 | ||
| dash_html_components==0.13.4 | ||
| dash==0.32.2 |
There was a problem hiding this comment.
should we lock on to rc releases (github branch) here so we are testing against the latest of everything?
There was a problem hiding this comment.
We're already planning on making these point to head of master / release-v1 soon
|
@bpostlethwaite A follow up to these is having a release-v1 of the dash-docs. Haven't included a task to test in at least of subset of existing apps when getting ready to push back into master. If you have a good subset in mind, would you mind creating an issue with some ideas on this in the |
This PR upgrades React to 16.6.1, and bumps the version up to
1.0.0-rc1.Relies on:
dash-core-components 1.0.0
dash-html-components 1.0.0
dash 1.0.0
===========================
@Marc-Andre-Rivet is hijacking this existing PR from @valentijnnieman 😄
Fixes https://github.com/plotly/dash-core/issues/4
release-v1