This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
June 2019 update component gen, and save updated attributes.html #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| * If the button/input is a submit button (type="submit"), this attribute specifies the browsing context (for example, tab, window, or inline frame) in which to display the response that is received after submitting the form. If this attribute is specified, it overrides the target attribute of the button's form owner. | ||
| */ | ||
| 'formTarget': PropTypes.string, | ||
|
|
There was a problem hiding this comment.
I agree with #118 (comment), we could indeed rename or exclude these files from the commits at some point. The only argument for keeping that at this point is that we do not fully trust our generation & testing steps yet.
Marc-Andre-Rivet
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #118 - without build artifacts, thx @Marc-Andre-Rivet
Noticed a couple of additions when I reran
generate-componentsjust now: forButton,formEncType,formMethod,formTarget; forSelect:autoComplete. They seem reasonable...While I was at it I had the script overwrite
data/attributes.htmlso we can see the diff there (though it's pretty messy)