Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

make sure tooltips aren't visible when parent slider isn't #878

Merged
merged 6 commits into from
Oct 27, 2020
Merged

make sure tooltips aren't visible when parent slider isn't #878

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3620e0e
make sure tooltips aren't visible when parent slider isn't
Oct 27, 2020
f3372f0
format
Oct 27, 2020
d45a318
add percy test
Oct 27, 2020
536a0dc
update changelog, format test, add comment for future maintainability
Oct 27, 2020
d805fad
make sure snapshot is taken of loaded DOM
Oct 27, 2020
950e383
changelog wording
Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/fragments/Slider.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ export default class Slider extends Component {
setProps({value});
}
}}
tipProps={tipProps}
tipProps={{
...tipProps,
getTooltipContainer: node => node,
}}
style={{position: 'relative'}}
value={value}
marks={truncatedMarks}
{...omit(
Expand Down