This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Async support - Lazy dcc.Graph and lazy plotlyjs #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 26, 2019 14:32
- lazy load plotly.js
# Conflicts: # dash_core_components/__init__.py
4 tasks
Closed
- async chunks min size & naming
…s into exp-dynamic-2
byronz
reviewed
Oct 10, 2019
| @@ -11,8 +11,9 @@ | |||
| import dash.testing.wait as wait | |||
|
|
|||
|
|
|||
| def test_grbs001_graph_without_ids(dash_dcc): | |||
| app = dash.Dash(__name__) | |||
| @pytest.mark.parametrize("is_eager", [True, False]) | |||
There was a problem hiding this comment.
@Marc-Andre-Rivet does this change make trouble for you?
There was a problem hiding this comment.
After a few tweaks and figuring out the equivalent functions vs. self., this seems to be working fine :)
…s into exp-dynamic-2
Marc-Andre-Rivet
changed the title
added 2 commits
October 17, 2019 10:46
|
@alexcjohnson Last concern / mystery solved for this PR.. https://github.com/plotly/dash-core-components/pull/616/files#r327786637 Amongst the mass of merges / tweaks for various unrelated changes that had to be done, I forgot I did this change for the tab tests. |
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ## [1.3.0] - 2019-10-08 | |||
| ### Added | |||
| - Added `search_value` prop to `Dropdown`, for server-side options loading/filtering. [#660](https://github.com/plotly/dash-core-components/pull/660) | |||
| - [#616](https://github.com/plotly/dash-core-components/pull/616) Async Graph and Plotly.js | |||
alexcjohnson
approved these changes
Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for plotly/dash-table#554
plotly-distfordash_core_components/plotly-x.xx.x.jsinstead of having two copies to keep in syncdcc.Graphtests in botheagerandlazymodewindow.Plotlyloading / behavior for lazy / eager / explicitly loaded Plotlyjs through assetNote:
plotly.js-distonly provides a non-minified version ofplotly.js, switched over to usingplotly.jsdirectly and resolving the desired js withresolve.aliasin webpack..