Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to v31.1.0 #287

Closed
wants to merge 8 commits into from
Closed

bump to v31.1.0 #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4325cab
bump to v31.2.1
BSd3v Apr 22, 2024
eace7ca
fixing deprecation
BSd3v Apr 22, 2024
722ecf8
updating changelog
BSd3v Apr 22, 2024
437ddcc
Merge remote-tracking branch 'upstream/main' into bump-v31.2
BSd3v Apr 23, 2024
b2348c7
Merge branch 'main' into bump-v31.2
ndrezn Apr 23, 2024
59484e4
bumping package-lock
BSd3v Apr 23, 2024
514c026
Update package.json
BSd3v Apr 23, 2024
51242e8
testing a delay on the test for updating info in the grid for the fla…
BSd3v Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,24 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D

### Changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a new version number added rather than unreleased similar to others

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreleased swaps to version number with the release of the new package, as we dont know what version these changes will be included in when adding. 😏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the release PR though?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you make the release in a separate PR. Along with npm updates.

- [#273](https://github.com/plotly/dash-ag-grid/pull/273) increased the timeout for `getApiAsync` to 2 minutes.
- [#281](https://github.com/plotly/dash-ag-grid/pull/281) webpack is now designed to build quicker, excludes `node_modules` and uses a different parser
- [#287](https://github.com/plotly/dash-ag-grid/pull/287) bumping to v`31.2.1` for the grid

### Added
- [#270](https://github.com/plotly/dash-ag-grid/pull/270)
- support for `eventListeners` to be added to the grid that get loaded upon `gridReady`
- `eventListeners` are added upon `gridReady` only, if you need to add or remove other event listeners, please use the `getApi` or `getApiAsync` methods
- added default for `selectedRows` to be `[]`

### Fixed
- [#283](https://github.com/plotly/dash-ag-grid/pull/283)
- `selectedRows` can now be passed along with the `rowData`
- fixes [#274](https://github.com/plotly/dash-ag-grid/issues/274)
- fixes [#282](https://github.com/plotly/dash-ag-grid/issues/282)
- [#287](https://github.com/plotly/dash-ag-grid/pull/287)
- `aggFuncs` can now be passes as an object from the grid to be mapped to functions
- fixes [#278](https://github.com/plotly/dash-ag-grid/issues/278)


## [31.0.1] - 2024-02-07

Expand Down
66 changes: 39 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-ag-grid",
"version": "31.0.1",
"version": "31.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @alexcjohnson -- I was wrong with the version bump; we follow the major version of Ag Grid only, so this would be a minor bump to 31.1.0. Sorry for the confusion here...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndrezn and @alexcjohnson

The main purpose of matching the the AG Grid versions is to give people an easy way to know the underlying AG Grid version. This makes it easier to know what version of their docs to use. This is important especially for Enterprise users because we have so few AG Grid Enterprise features documented.

Even in minor releases AG Grid adds a lot of features (especially Enterprise features) and deprecates props. I think it's helpful to match their release numbers as closely as possible. Given their rapid release schedule, I doubt we would ever need to release our own minor version before they would have another one out anyway.

Would you reconsider and make this release 31.2.0?

"description": "Dash wrapper around AG Grid, the best interactive data grid for the web.",
"repository": {
"type": "git",
Expand Down Expand Up @@ -31,9 +31,9 @@
"dependencies": {
"@emotion/react": "^11.11.3",
"@emotion/styled": "^11.11.0",
"ag-grid-community": "31.1.1",
"ag-grid-enterprise": "31.1.1",
"ag-grid-react": "31.1.1",
"ag-grid-community": "31.2.1",
"ag-grid-enterprise": "31.2.1",
"ag-grid-react": "31.2.1",
ndrezn marked this conversation as resolved.
Show resolved Hide resolved
"@mui/icons-material": "^5.15.7",
"@mui/material": "^5.15.7",
"d3-format": "^3.1.0",
Expand Down Expand Up @@ -85,4 +85,4 @@
"browserslist": [
"last 7 years and not dead"
]
}
}
2 changes: 1 addition & 1 deletion src/lib/fragments/AgGrid.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ export default class DashAgGrid extends Component {
const {rowModelType, eventListeners} = this.props;

if (rowModelType === 'infinite') {
params.api.setDatasource(this.getDatasource());
params.api.setGridOption('datasource', this.getDatasource());
}

if (eventListeners) {
Expand Down
6 changes: 6 additions & 0 deletions tests/test_selected_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def test_sr2_selected_rows_rowdata(dash_duo):
dag.AgGrid(
id='grid',
columnSize="sizeToFit",
columnDefs=[{'field': 'A'}],
dashGridOptions={
"rowHeight": None,
"domLayout": "normal",
Expand Down Expand Up @@ -152,6 +153,8 @@ def update_selected_row_info(selected_rows):

grid = utils.Grid(dash_duo, "grid")

grid.wait_for_header_text(0, 'A')

dash_duo.find_element('#update-button').click()

grid.wait_for_cell_text(0, 0, "1")
Expand Down Expand Up @@ -186,6 +189,7 @@ def test_sr3_selected_rows_modes(dash_duo):
dag.AgGrid(
id='grid',
columnSize="sizeToFit",
columnDefs=[{'field': 'A'}],
dashGridOptions={
"rowHeight": None,
"domLayout": "normal",
Expand Down Expand Up @@ -245,6 +249,8 @@ def update_selected_row_info(selected_rows):

grid = utils.Grid(dash_duo, "grid")

grid.wait_for_header_text(0, 'A')

dash_duo.find_element('#update-button').click()

grid.wait_for_cell_text(0, 0, "1")
Expand Down
Loading