Dangerously_allow_code and Function Parsing updates #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabling when they may be expressions instead
…ed from the grid initial layer - Allowing for the style conditions to utilize other namespace functions, variables, and d3 formatting
- created a unified function parser to be easier to maintain - brought the props to iterate through into a separate js file - switched to keeping `params` together instead of splitting into separate keys, to allow for easier transition to using AG Grid docs - updated `test/test_add_remove_update_rows.py` to apply the new variable configuration
BSd3v
changed the title
- adjusting (`updateColumnWidths()`) `columnSize` to only be auto called with the `onGridReady` function
…action` - Adjusted `rowTransaction` to use `applyTransactionAsync` by default unless `rowTransaction.async` is passed as `false`
…action` - Adjusted `rowTransaction` to use `applyTransactionAsync` by default unless `rowTransaction.async` is passed as `false` - updated test file to test async updates
…ey exists in it.
…grid level, no need to attach to `columnDefs`
…ite `rowModelType` was selected.
alexcjohnson
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Nice! Need to resolve conflicts, and let's remove the commented-out code block - it's there in the git history if we want it back 😄 - then this is ready to go 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dangerously_allow_codeis not passedcolumnDefdangerously_allow_codeto allow for the prop to be placed only on the grid levelutils/functionVars.jsfileparamstogether instead of splitting into separate keys, to allow for easier transition to using AG Grid docstest/test_add_remove_update_rows.pyto apply the new variable configuration