allowing more functions #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
…nctions added test for setting `popupParent`
tests/test_popupparent.py
Outdated
| action = utils.ActionChains(dash_duo.driver) | ||
| action.double_click(grid.get_cell(0, 0)).perform() | ||
|
|
||
| dash_duo.find_element('body > .ag-popup') |
There was a problem hiding this comment.
Nice test - and nice use of > in the selector to verify that it's a direct child! Do you want to include something to assert that there's a dmc.Select in the popup? Like dash_duo.find_element('body > .ag-popup .mantine-select') or whatever class it should have?
There was a problem hiding this comment.
Yeah, we can definitely do this.
…ed through to allow for functions to be parsed
added `getContextMenuItems` as a function, pending test
This was
linked to
issues
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding filter to be allowed as a functional component without params