-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for filterModel
#111
Conversation
- info from the grid (read-only) (plotly#109) - added output for `test_filter` - added check for action props to delay until the grid is ready (plotly#99) - set the default `dashGridOptions` to `{}` (plotly#97)
…filter doesnt match the grid already - Moved the `setProps` on the filter change event to be only once during the event, to avoid clearing filters accidentally
- made adjustments for `setProps` according to discuss on PR - adding tests for templates - updated changelog
CHANGELOG.md
Outdated
@@ -76,6 +76,9 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D | |||
- allowed for functions, styleConditions and regular dictionaries to be passed to the `cellStyle` on all levels | |||
- added `rowId` to `cellClicked` data | |||
|
|||
- [#111](https://github.com/plotly/dash-ag-grid/pull/111) | |||
- fixing templates to only populate when `dangerously_allow_code=True` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That note belongs under Fixed
- but we should also note the addition of filterModel
in the Added
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted via 679ed74
Co-authored-by: Alex Johnson <alex@plot.ly>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 💃 pending changelog edit.
test_filter