Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for filterModel #111

Merged
merged 10 commits into from
Mar 30, 2023
Merged

adding support for filterModel #111

merged 10 commits into from
Mar 30, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented Mar 24, 2023

- info from the grid (read-only) (plotly#109)
- added output for `test_filter`
- added check for action props to delay until the grid is ready (plotly#99)
- set the default `dashGridOptions` to `{}` (plotly#97)
BSd3v added 4 commits March 24, 2023 15:29
…filter doesnt match the grid already

- Moved the `setProps` on the filter change event to be only once during the event, to avoid clearing filters accidentally
BSd3v added 2 commits March 28, 2023 12:46
- made adjustments for `setProps` according to discuss on PR
- adding tests for templates
- updated changelog
@BSd3v BSd3v linked an issue Mar 28, 2023 that may be closed by this pull request
CHANGELOG.md Outdated
@@ -76,6 +76,9 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D
- allowed for functions, styleConditions and regular dictionaries to be passed to the `cellStyle` on all levels
- added `rowId` to `cellClicked` data

- [#111](https://github.com/plotly/dash-ag-grid/pull/111)
- fixing templates to only populate when `dangerously_allow_code=True`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That note belongs under Fixed - but we should also note the addition of filterModel in the Added section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted via 679ed74

Co-authored-by: Alex Johnson <alex@plot.ly>
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 💃 pending changelog edit.

@BSd3v BSd3v merged commit fd8ffe8 into plotly:dev Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

securing Overlays Feature Request -- return filter query autoSizeAllColumns bug
2 participants