-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volto form block fixes #6370
base: main
Are you sure you want to change the base?
Volto form block fixes #6370
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add release notes and fix the lint errors and failing unit tests.
This PR should also render its Storybook. We recently merged a PR that should fix the pull request preview build on Netlify: The Netlify build currently fails to recognize changes in the most recent commit: |
6d9bc8a
to
be53373
Compare
988b47e
to
dd5a050
Compare
This caused the object_browser widget loosing the mode and return props which got the default "multiple", "multiple" values even when "image", "single" was desired. As a consequence this broke the preview images.
dd5a050
to
dc2c6a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only the .pot
and news, both of which look good, with a couple of MyST markup enhancements and a question.
Will this PR need developer documentation? For example:
packages/volto/src/components/manage/Widgets/CheckboxGroupWidget.jsx
Outdated
Show resolved
Hide resolved
The issues are fixed. The page for those widgets is about declaring widgets in the backend not the frontend so doesn't make sense to add anything on that page. |
Done |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #