Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volto form block fixes #6370

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Volto form block fixes #6370

wants to merge 37 commits into from

Conversation

robgietema
Copy link
Member

@robgietema robgietema commented Oct 3, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 5880acb
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6769d7246054400008d8e08c

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release notes and fix the lint errors and failing unit tests.

@davisagli davisagli requested a review from sneridagh October 4, 2024 00:59
@stevepiercy
Copy link
Collaborator

This PR should also render its Storybook. We recently merged a PR that should fix the pull request preview build on Netlify:
#6410

The Netlify build currently fails to recognize changes in the most recent commit:
https://app.netlify.com/sites/plone-components/deploys/670fb4bff3f6740008e0d09f

@robgietema robgietema force-pushed the volto-form-block-fixes branch 2 times, most recently from 6d9bc8a to be53373 Compare November 5, 2024 12:55
@robgietema robgietema force-pushed the volto-form-block-fixes branch from 988b47e to dd5a050 Compare December 20, 2024 18:55
@robgietema robgietema force-pushed the volto-form-block-fixes branch from dd5a050 to dc2c6a4 Compare December 20, 2024 18:55
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed only the .pot and news, both of which look good, with a couple of MyST markup enhancements and a question.

Will this PR need developer documentation? For example:

packages/volto/news/6370.feature Outdated Show resolved Hide resolved
packages/volto/news/6370.feature Outdated Show resolved Hide resolved
packages/volto/news/6370.feature Outdated Show resolved Hide resolved
@robgietema
Copy link
Member Author

I reviewed only the .pot and news, both of which look good, with a couple of MyST markup enhancements and a question.

Will this PR need developer documentation? For example:

The issues are fixed. The page for those widgets is about declaring widgets in the backend not the frontend so doesn't make sense to add anything on that page.

@robgietema
Copy link
Member Author

Please add release notes and fix the lint errors and failing unit tests.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants