Add visually-hidden class #6356
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ichim-david
reviewed
Oct 1, 2024
| @@ -61,3 +61,16 @@ body:not(.has-sidebar):not(.has-sidebar-collapsed) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
there might be something from semantic already for visually hidden
|
@JeffersonBledsoe @ichim-david if we do this, we need that also in |
|
@JeffersonBledsoe it seems you pushed more changes than the needed in this PR. Can you take a look, please? you deleted things and files, that we cannot remove. |
JeffersonBledsoe
force-pushed
the
visually-hidden-utility-class
branch
from
a21a81b
to
9da45c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
visually-hiddenclass which is useful in situations where you want to provide additional information to Assistive Technology and an aria-label may not be appropriate.Questions