Upgrade to Cypress 12.17.1 (latest)

cypress/support/commands.js

@@ -1,4 +1,3 @@
-import '@testing-library/cypress/add-commands';
 import { getIfExists } from '../helpers';
 import { ploneAuth } from './constants';
 
@@ -21,6 +20,8 @@ const ploneAuthObj = {
   pass: ploneAuth[1],
 };
 
+export * from './volto-slate';
+
 // --- isInViewport ----------------------------------------------------------
 Cypress.Commands.add('isInViewport', (element) => {
   cy.get(element).then(($el) => {

cypress/support/e2e.js

@@ -1,3 +1,4 @@
+import '@testing-library/cypress/add-commands';
 import 'cypress-axe';
 import 'cypress-file-upload';
 import './commands';
@@ -28,5 +29,3 @@ afterEach(function () {
     teardown();
   }
 });
-
-export * from './volto-slate';

cypress/tests/core/volto-slate/01-block-slate-title-description.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/02-block-slate.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/03-block-slate.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach, getSlateBlockValue } from '../../../support/e2e';
+import { slateBeforeEach, getSlateBlockValue } from '../../../support/commands';
 
 describe('Block Tests', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/04-block-focus.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/05-block-slate-format-basics.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: Basic text format', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/06-block-slate-format-link.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: Links', () => {
   beforeEach(slateBeforeEach);
@@ -66,31 +66,31 @@ describe('Block Tests: Links', () => {
       'Colorless green ideas{shift}{enter} {shift}{enter}sleep furiously.',
     );
 
-    cy.log("Adding link")
+    cy.log('Adding link');
     cy.setSlateSelection('green', 'furiously');
     cy.clickSlateButton('Add link');
 
     cy.get('.slate-toolbar .link-form-container input').type(
       'https://google.com{enter}',
     );
 
-    cy.log("Removing link");
+    cy.log('Removing link');
     cy.setSlateSelection('ideas');
     cy.clickSlateButton('Edit link');
     cy.get('.slate-inline-toolbar .cancel').click();
 
-    cy.log("Re-add link")
+    cy.log('Re-add link');
     cy.setSlateSelection('Colorless', 'furiously');
     cy.clickSlateButton('Add link');
 
     cy.get('.slate-toolbar .link-form-container input').type(
       'https://google.com{enter}',
     );
 
-    cy.log("Save");
+    cy.log('Save');
     cy.toolbarSave();
 
-    cy.log("then the page view should contain a link");
+    cy.log('then the page view should contain a link');
     cy.get('[id="page-document"] p a')
       .should('have.attr', 'href')
       .and('include', 'https://google.com');

cypress/tests/core/volto-slate/07-block-slate-format-ulist.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: Bulleted lists', () => {
   beforeEach(slateBeforeEach);
@@ -47,7 +47,7 @@ describe('Block Tests: Bulleted lists', () => {
 
     cy.log('then the page view should contain a link');
     cy.get('#view #page-document p').its('length').should('eq', 1);
-    cy.get('#view #page-document p').should('have.text', "");
+    cy.get('#view #page-document p').should('have.text', '');
   });
 
   it('As editor I can remove bulleted lists', function () {

cypress/tests/core/volto-slate/08-block-slate-format-olist.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: Numbered lists', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/09-block-slate-slashmenu.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('SlashMenu Test: Shortcuts', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/24-block-slate-format-boldlists.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: Bold Bulleted lists', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/25-block-slate-paste-images.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: paste external images', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/27-block-slate-paste-html.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/e2e';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: external text containing html contents/tags ', () => {
   beforeEach(slateBeforeEach);

cypress/tests/core/volto-slate/28-table-block-slate-paste.js

@@ -1,4 +1,4 @@
-import { slateBeforeEach } from '../../../support/volto-slate';
+import { slateBeforeEach } from '../../../support/commands';
 
 describe('Block Tests: pasting content in table block', () => {
   beforeEach(slateBeforeEach);

docs/source/upgrade-guide/index.md

@@ -89,6 +89,26 @@ If you want to retain the old behavior (and no use `apiExpanders` at all), you n
 config.settings.apiExpanders = [];
 ```
 
+### Cypress upgraded to 12.17.1
+
+As usual in a Volto major version release, Cypress has been upgraded to the latest version to date.
+There are no major changes to the way the tests are implemented and run.
+
+However, it could be that your Cypress boilerplate must be updated in your projects and add-ons if you use `@testing-library/cypress` in your tests.
+This is due to a change in how the default commands are now built internally and in `@testing-library/cypress`.
+
+You need to move the import:
+
+```js
+import '@testing-library/cypress/add-commands';
+```
+
+from {file}`cypress/support/commands.js` to {file}`cypress/support/e2e.js`, in case you have it in there.
+
+This is because the overrides that `@testing-library/cypress` introduce can be run only once.
+Since there are some commands that can call exports in {file}`cypress/support/commands.js`, this import may be run more than once, and then it errors.
+So you have to make sure that import is run only once while the tests are run.
+
 ### New Image component
 
 ```{versionadded} 17.0.0-alpha.21
@@ -101,6 +121,7 @@ It requires the latest version of `plone.restapi` (>=8.42.0) installed in the ba
 The `utils.js` file of the Teaser block was removed because it is no longer used.
 You can consider removing it if you were shadowing it in your project.
 
+
 (volto-upgrade-guide-16.x.x)=
 
 ## Upgrading to Volto 16.x.x

news/4981.internal

@@ -0,0 +1 @@
+Upgrade to Cypress 12.17.1 (latest) @sneridagh

package.json

@@ -239,7 +239,7 @@
     "@loadable/server": "5.14.0",
     "@loadable/webpack-plugin": "5.15.2",
     "@plone/scripts": "2.1.2",
-    "@testing-library/cypress": "8.0.7",
+    "@testing-library/cypress": "9.0.0",
     "@testing-library/jest-dom": "5.16.4",
     "@testing-library/react": "12.1.5",
     "@testing-library/react-hooks": "8.0.1",
@@ -257,8 +257,8 @@
     "connected-react-router": "6.8.0",
     "crypto-random-string": "3.2.0",
     "css-loader": "5.2.7",
-    "cypress": "11.1.0",
-    "cypress-axe": "1.0.0",
+    "cypress": "12.17.1",
+    "cypress-axe": "1.4.0",
     "cypress-file-upload": "5.0.8",
     "debug": "4.3.2",
     "decorate-component-with-props": "1.2.1",

packages/volto-testing/news/4981.breaking

@@ -0,0 +1 @@
+Update to Cypress 12.17.1 @sneridagh

packages/volto-testing/package.json

@@ -56,12 +56,12 @@
     "access": "public"
   },
   "dependencies": {
-    "@testing-library/cypress": "8.0.7",
+    "@testing-library/cypress": "9.0.0",
     "@testing-library/jest-dom": "5.16.4",
     "@testing-library/react": "12.1.5",
     "axe-core": "4.6.3",
-    "cypress": "11.1.0",
-    "cypress-axe": "1.0.0",
+    "cypress": "12.17.1",
+    "cypress-axe": "1.4.0",
     "cypress-file-upload": "5.0.8"
   },
   "devDependencies": {