Update relations control panel to use new result format from relations endpoint #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
davisagli
force-pushed
the
relations-control-panel-result-format
branch
from
777d880
to
433b200
Compare
ksuess
force-pushed
the
relations-control-panel-result-format
branch
from
433b200
to
d4ec7ef
Compare
ksuess
approved these changes
May 20, 2023
There was a problem hiding this comment.
Thank you @davisagli !
With a fix on plone.restapi correcting the format for broken links according the format for valid relations, this is fine and the broken links show up in the panel as expected and like before. Yeah!
|
For testing purpose https://github.com/collective/example.contenttype can be installed. Then create two instances A and B. Create a relation. Delete B. Voilà a broken relation appears in the panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksuess I tried to update the control panel to use the updated result format that you worked on this morning. Please check my work (especially the broken relations component, which I'm not sure how to test).
Edited to add: I was working on this quickly at the end of the day and I am not confident it is right yet.