Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete content modal for link integrity #4786

Merged
merged 16 commits into from
Sep 18, 2023

Conversation

danalvrz
Copy link
Contributor

@danalvrz danalvrz commented May 18, 2023

Regarding: #4339

Requires:
#1636
#4787

Screenshots:
Screenshot 2023-05-18 at 20 41 42
Screenshot 2023-05-18 at 20 42 03

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 66eb68d
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6505ea3b3a08be00084a8626

@cypress
Copy link

cypress bot commented May 18, 2023

Passing run #6458 ↗︎

0 529 20 0 Flakiness 0

Details:

minor link fix
Project: Volto Commit: 5169ea86a7
Status: Passed Duration: 16:50 💡
Started: Jul 18, 2023 7:57 PM Ended: Jul 18, 2023 8:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@danalvrz danalvrz changed the title WIP: Update delete content modal for link integrity Update delete content modal for link integrity May 19, 2023
@danalvrz danalvrz marked this pull request as ready for review May 19, 2023 07:32
Copy link
Contributor

@pgrunewald pgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some smaller things, that need a closer look.

locales/en/LC_MESSAGES/volto.po Outdated Show resolved Hide resolved
src/components/manage/Contents/Contents.jsx Outdated Show resolved Hide resolved
src/components/manage/Contents/Contents.jsx Outdated Show resolved Hide resolved
src/components/manage/Contents/Contents.jsx Outdated Show resolved Hide resolved
cypress/tests/core/basic/content.js Show resolved Hide resolved
@sneridagh
Copy link
Member

@danalvrz what's the status of this one?

@danalvrz
Copy link
Contributor Author

@sneridagh I believe it is ready to be reviewed, considering it still needs #1636 to be merged

@tisto
Copy link
Sponsor Member

tisto commented Sep 16, 2023

@sneridagh we need to release plone.restapi 9, then we can merge this. Though, this would introduce a hard requirement on plone.restapi 9 unless we can make this feature somehow backwards compatible.

@davisagli
Copy link
Sponsor Member

@tisto @sneridagh I updated it so that it degrades gracefully when using an older version of plone.restapi that does not include items_total in the @linkintegrity response. In that case it will not be able to warn about deleting contained items, but the rest of the linkintegrity warnings should still work.

@tisto
Copy link
Sponsor Member

tisto commented Sep 17, 2023

@davisagli awesome! Thanks!

@sneridagh sneridagh merged commit 5c3dbad into master Sep 18, 2023
41 checks passed
@sneridagh sneridagh deleted the linkintegrity-modal-update branch September 18, 2023 09:20
sneridagh added a commit that referenced this pull request Sep 18, 2023
* master:
  Update delete content modal for link integrity (#4786)
erral pushed a commit that referenced this pull request Sep 19, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh added a commit that referenced this pull request Sep 19, 2023
* master: (31 commits)
  Refactor Content Rename Model (#4971)
  Refactor Content Tags Modal  (#4970)
  Refactor Content workflow Modal  (#4969)
  Refactor Content Property Model  (#4968)
  Refactor Sidebar (#4965)
  Refactor PersonalTool component (#4954)
  Fix standalone navigation action call if expander is set (#5197)
  Fix api convenience buildout build
  Fix instruction to fetch add-on from repo (#5196)
  Remove JSON files from being linted by ESlint, since it's not its pur… (#5194)
  Release generate-volto 7.0.0-alpha.8
  Add missing empty lock to acceptance generator addon folder (#5193)
  Release generate-volto 7.0.0-alpha.7
  Release 17.0.0-alpha.27
  TypeScript support in core (#4662)
  Update delete content modal for link integrity (#4786)
  Add external className to slate Link view. (#5188)
  Release generate-volto 7.0.0-alpha.6
  Fix addon i18n local command when executed outside the scope of a Volto project. (#5181)
  Release 17.0.0-alpha.26
  ...
sneridagh pushed a commit that referenced this pull request Nov 14, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants