Check project name for special chars (#72) #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrTango
requested changes
May 27, 2022
| @@ -81,6 +81,8 @@ def create(context, template, name): | |||
| raise NoSuchValue( | |||
| context.command.name, template, possibilities=reg.get_templates() | |||
| ) | |||
| if set(name).intersection(set(string.punctuation)): | |||
There was a problem hiding this comment.
As i mentioned, a dash or a underscore is a legal sign for a Python Project name.
What we need to do is, to normalizes it for the module names and in ZCML.
For now you can add a note to the docs, as you suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick and dirty fix to check for any special characters in the given name of the package.
Enhancement required for fixing #72