Plone 6: Always use lines property for behaviors, no longer ulines #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated ulines. Part of plone/Products.CMFPlone#3305. Note: I have switched coredev 5.2 to use `plone.dexterity` branch 2.x.
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 20, 2021
|
Go on with it, I need to start over anyway. |
|
FYI: I created a branch for Plone 5.2 in advance, but I did not activate it in 5.2 coredev. |
|
Tests are green. Jenkins on 5.2 can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ulinesis deprecated, and on Plone 6 it is the same aslines.Part of plone/Products.CMFPlone#3305.
We have an upgrade step in
plone.app.upgradewhich replaces existingulinesproperties, so we should avoid adding new ones.Note: I have switched coredev 5.2 to use
plone.dexteritybranch 2.x.@jensens I am happy to revert this PR to draft status if you want to continue your cleanup PR #160 first.