Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content.FTIAwareSpecification.__get__ uses the wrong interface declaration type #186

Open
d-maurer opened this issue Aug 15, 2023 · 1 comment
Open

content.FTIAwareSpecification.__get__ uses the wrong interface declaration type #186

d-maurer opened this issue Aug 15, 2023 · 1 comment

Comments

@d-maurer
Copy link

plone.dexterity/plone/dexterity/content.py

Line 196 in aa6bb35

all_spec = Implements(*dynamically_provided)

uses Implements (instead of Provides) for the return value. Implements values are (unlike Provides values) not well designed for caching. This results in the memory leak described in "plone/Products.CMFPlone#3829".
mamico added a commit that referenced this issue Aug 17, 2023
@mamico
change interface declaration type #186
70a42d5
@mamico
Copy link
Member

mamico commented Aug 17, 2023

I've opened a draft PR with @d-maurer suggestion, but I think could be a lot of side-effects on code and tests.

In any case, it perfectly solves what I saw here plone/Products.CMFPlone#3829 (comment)

@mamico mamico mentioned this issue Aug 17, 2023
Merged
jensens pushed a commit that referenced this issue Aug 27, 2023
@mamico @jensens
change interface declaration type #186
f65fe3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mamico @d-maurer