Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple editors - Plone 5.2 #132

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Oct 18, 2021

Depends on plone/plone.app.textfield#45

Antoine Duchêne contributor agreement is being prepared. Antoine's contributor agreement is now in.

Use plone.app.textfield branch
@mister-roboto
Copy link

@duchenean you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

Use default editor registry setting
@mister-roboto
Copy link

@duchenean you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@jensens jensens changed the title WIP enable multiple editors - Plone 5.2 Enable multiple editors - Plone 5.2 Oct 19, 2021
@gotcha gotcha closed this Nov 17, 2021
@gotcha gotcha reopened this Nov 17, 2021
@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@gotcha
Copy link
Member Author

gotcha commented Nov 17, 2021

@jenkins-plone-org please run jobs

@gotcha
Copy link
Member Author

gotcha commented Nov 17, 2021

Builds/jobs have been launched with plone/plone.app.textfield#45

@mauritsvanrees Should plone.app.textfield be added to https://github.com/plone/buildout.coredev/blob/5.2/checkouts.cfg ? Misunderstanding, sorry.

@gotcha
Copy link
Member Author

gotcha commented Nov 18, 2021

@mauritsvanrees

I did relaunch tests.

1 failing robot test across the four builds.

@gotcha gotcha marked this pull request as draft November 18, 2021 16:14
@gotcha
Copy link
Member Author

gotcha commented Nov 18, 2021

This is still in draft as the dependency on a new plone.app.textfield release is missing.

@gotcha
Copy link
Member Author

gotcha commented Nov 25, 2021

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees marked this pull request as ready for review November 26, 2021 08:29
@mauritsvanrees mauritsvanrees merged commit 07c3bcc into plone:3.2.x Nov 26, 2021
@mauritsvanrees
Copy link
Sponsor Member

I have released 3.2.3.

@gotcha
Copy link
Member Author

gotcha commented Nov 26, 2021

@mauritsvanrees Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants