Skip to content

Commit

Permalink
Fix deprecation warning
Browse files Browse the repository at this point in the history 
Fixes plone/Products.CMFPlone#2605
  • Loading branch information
@ale-rt
ale-rt committed Oct 29, 2018
1 parent 1a205fc commit c93d73b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ New features:

Bug fixes:

- *add item here*
- Fix deprecation warning
(https://github.com/plone/Products.CMFPlone/issues/2605) [ale-rt]


3.0.6 (2018-09-27)
Expand Down
3 changes: 2 additions & 1 deletion plone/app/z3cform/wysiwyg/widget.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import Acquisition
import logging
import warnings
import z3c.form.browser.textarea
import z3c.form.interfaces
import z3c.form.widget
Expand Down Expand Up @@ -43,7 +44,7 @@ def update(self):
@implementer(z3c.form.interfaces.IFieldWidget)
def WysiwygFieldWidget(field, request):
"""IFieldWidget factory for WysiwygWidget."""
logger.warn(
warnings.warn(
'plone.app.z3cform.wysiwyg.WysiwygFieldWidget is deprecated and'
'will be removed in Plone 5.1',
DeprecationWarning,
Expand Down

1 comment on commit c93d73b

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ale-rt Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/130/violations

plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:667:19: T000 Todo note found.
plone/app/z3cform/widget.py:681:47: T000 Todo note found.
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:159:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:169:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:18: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.