Fix bug when registering a user #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PanelAdapter when registering a user the properties-setter in plone.app.users.browser.register.BaseRegistrationForm.applyProperties uses ``adapter.schema = schema`` to set schema on plone.app.users.browser.userdatapanel.UserDataPanelAdapter. That used the __setattr__ of its super but UserDataPanelAdapter.schema was a property.
jensens
added a commit
that referenced
this pull request
Feb 1, 2016
Fix bug when registering a user
jensens
added a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 1, 2016
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a setter to the attribute
schemaof UserDataPanelAdapter.When registering a user the properties-setter in
plone.app.users.browser.register.BaseRegistrationForm.applyPropertiesusesadapter.schema = schemato set schema onplone.app.users.browser.userdatapanel.UserDataPanelAdapter.That operation used the
__setattr__-method of its super butUserDataPanelAdapter.schemawas a property so that had to fail. We also useobject.__getattribute__to bypass the getter of the super that checked for schema and would result in a infinite recursion.