Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError while saving in @@personal-information view #126

Closed
verena-rh opened this issue Jun 6, 2024 · 2 comments · Fixed by #129
Closed

AttributeError while saving in @@personal-information view #126

verena-rh opened this issue Jun 6, 2024 · 2 comments · Fixed by #129
Assignees
@mauritsvanrees

Comments

@verena-rh
Copy link

verena-rh commented Jun 6, 2024 •
edited
Loading

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

In the @@personal-information view I get the following error when I make changes but the portrait image remains the same:

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 391, in publish_module
  Module ZPublisher.WSGIPublisher, line 285, in publish
  Module ZPublisher.mapply, line 98, in mapply
  Module ZPublisher.WSGIPublisher, line 68, in call_object
  Module plone.app.users.browser.userdatapanel, line 92, in __call__
  Module z3c.form.form, line 233, in __call__
  Module plone.z3cform.fieldsets.extensible, line 62, in update
  Module plone.z3cform.patch, line 31, in GroupForm_update
  Module z3c.form.group, line 145, in update
  Module plone.app.z3cform.csrf, line 21, in execute
  Module z3c.form.action, line 98, in execute
  Module z3c.form.button, line 301, in __call__
  Module z3c.form.button, line 159, in __call__
  Module plone.app.users.browser.account, line 299, in handleSave
  Module plone.app.users.browser.account, line 276, in validate_portrait
AttributeError: 'NOT_CHANGED' object has no attribute 'open'

What I did:

Added an portrait and saved. Then edit again, leave the portrait unchanged and save.

What I expect to happen:

The changes are saved.

What actually happened:

Get the above error message.

What version of Plone/ Addons I am using:

Plone 6.0.11.1 Classic
plone.app.users 3.0.6
@mauritsvanrees mauritsvanrees self-assigned this Jun 6, 2024
@mauritsvanrees
Copy link
Sponsor Member

Confirmed. This is caused by PR #123. Workaround is to switch back to plone.app.users 3.0.5.
I am working on a proper fix.

mauritsvanrees added a commit that referenced this issue Jun 6, 2024
@mauritsvanrees
Fix error on personal-information page when you leave an existing por…
cd12376 
…trait unchanged.

The previous release added validation, but this caused a regression.
Fixes #126
@mauritsvanrees mauritsvanrees mentioned this issue Jun 6, 2024
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jun 7, 2024
@jensens
[fc] Repository: plone.app.users
3c7e6c9 
Branch: refs/heads/master
Date: 2024-06-06T17:48:29+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.users@cd12376

Fix error on personal-information page when you leave an existing portrait unchanged.

The previous release added validation, but this caused a regression.
Fixes plone/plone.app.users#126

Files changed:
A news/126.bugfix
M plone/app/users/browser/account.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2024-06-07T10:00:19-04:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.users@2c8f9d0

Merge pull request #129 from plone/maurits-fix-portrait-not-changed

Fix error on personal-information when leaving existing portrait unchanged

Files changed:
A news/126.bugfix
M plone/app/users/browser/account.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jun 7, 2024
@jensens
[fc] Repository: plone.app.users
bd392ec 
Branch: refs/heads/master
Date: 2024-06-06T17:48:29+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.users@cd12376

Fix error on personal-information page when you leave an existing portrait unchanged.

The previous release added validation, but this caused a regression.
Fixes plone/plone.app.users#126

Files changed:
A news/126.bugfix
M plone/app/users/browser/account.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2024-06-07T10:00:19-04:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.users@2c8f9d0

Merge pull request #129 from plone/maurits-fix-portrait-not-changed

Fix error on personal-information when leaving existing portrait unchanged

Files changed:
A news/126.bugfix
M plone/app/users/browser/account.py
@mauritsvanrees
Copy link
Sponsor Member

I have released plone.app.users 3.0.7 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error on personal-information when leaving existing portrait unchanged plone/plone.app.users
2 participants
@mauritsvanrees @verena-rh