Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aq_base(obj) instead of obj.aq_base #84

Closed
jensens opened this issue Sep 13, 2016 · 0 comments
Closed

aq_base(obj) instead of obj.aq_base #84

jensens opened this issue Sep 13, 2016 · 0 comments

Comments

@jensens
Copy link
Sponsor Member

jensens commented Sep 13, 2016

For some reason at
https://github.com/plone/plone.app.upgrade/blob/master/plone/app/upgrade/v50/final.py#L73
the obj may not have an acquisition-wrapper (due to prior problems obj is a list in our case, but this must not stop the migration process here). So attribute access fails and migration breaks.

Using aq_base(obj) instead of obj.aq_base is considered best practice and has to be used here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant