Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #97 i.e. allow for MultiPath Queries #98

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Issue #97 i.e. allow for MultiPath Queries #98

merged 5 commits into from
Jul 14, 2020

Conversation

gogobd
Copy link
Contributor

@gogobd gogobd commented Jul 1, 2020

fixing issue #97

@mister-roboto
Copy link

@gogobd thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@gogobd
Copy link
Contributor Author

gogobd commented Jul 3, 2020

@jenkins-plone-org please run jobs

@gogobd gogobd changed the title Support multiple Translation Group paths Issue #97 i.e. allow for MultiPath Queries Jul 3, 2020
@gogobd
Copy link
Contributor Author

gogobd commented Jul 3, 2020

This PR just manages MultiPath Queries - it parses through all of them and allows multiple translation groups.

@jensens
Copy link
Sponsor Member

jensens commented Jul 7, 2020

See my PR #99 for a more generic solution

@mister-roboto
Copy link

gogo your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

1 similar comment
@mister-roboto
Copy link

gogo your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@gogobd
Copy link
Contributor Author

gogobd commented Jul 13, 2020

@jenkins-plone-org please run jobs

@mister-roboto
Copy link

gogo your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@gogobd
Copy link
Contributor Author

gogobd commented Jul 14, 2020

@jenkins-plone-org please run jobs

2 similar comments
@gogobd
Copy link
Contributor Author

gogobd commented Jul 14, 2020

@jenkins-plone-org please run jobs

@gogobd
Copy link
Contributor Author

gogobd commented Jul 14, 2020

@jenkins-plone-org please run jobs

@jensens jensens merged commit 6ba125e into master Jul 14, 2020
@jensens jensens deleted the fix_issue_97 branch July 14, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants