Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix: change test date to June instead of May #128

Merged
merged 1 commit into from
May 4, 2023

Conversation

mauritsvanrees
Copy link
Sponsor Member

This temporarily fixes a testing error. See #127. This gives us one month to come up with a proper fix.

… a testing error.

See #127.
Needs a proper fix within a month.
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Sponsor Member Author

gh-actions tests are green. I merge this now to fix a broken Jenkins.

@mauritsvanrees mauritsvanrees merged commit 4dafd5d into master May 4, 2023
@mauritsvanrees mauritsvanrees deleted the maurits-stable-now-moved-to-june-issue-127 branch May 4, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants