-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: use mxdev #931
Closed
Closed
POC: use mxdev #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packages. This uses `uv` for speed. pip-bootstrap Pip: Bootstrap a venv for tests (future: several venvs with less installed) pip-test Pip: Run only a few unit tests, as proof of concept. pip-update Pip: Update a venv for tests (future: several venvs with less installed)
Created by: `./venvs/test/bin/mxdev -c mxdev.ini -n`
mxdev should do this, but I think it fails because these packages have capital letters. Same would be true for Zope, but we do not notice at this moment, because it is not pinned in the versions.cfg of Zope master.
Otherwise the CMFPlone tests are not found when CMFPlone is an editable install. Adding `--path src` does not work. You get this error: ``` ModuleNotFoundError: No module named 'Products.CMFPlone.Products' ```
mauritsvanrees
added a commit
that referenced
this pull request
Aug 29, 2024
This combines three PRs: * #903 * #931 * #932 See `README-make.md` for instructions. This actually needs a change in `Products.CMFPlone`: it needs a `five:registerPackage`. Otherwise the Zope instance only works with a release of Products.CMFPlone, and not with an editable install (or src checkout). I will make a PR for that.
mauritsvanrees
added a commit
that referenced
this pull request
Aug 29, 2024
This is part of plone/Products.CMFPlone#3670 This combines three PRs: * #903 * #931 * #932 See `README-make.md` for instructions. This actually needs a change in `Products.CMFPlone`: it needs a `five:registerPackage`. Otherwise the Zope instance only works with a release of Products.CMFPlone, and not with an editable install (or src checkout). I will make a PR for that.
Closing this in favour of #945. |
mauritsvanrees
added a commit
that referenced
this pull request
Sep 10, 2024
This is part of plone/Products.CMFPlone#3670 This combines three PRs: * #903 * #931 * #932 See `README-make.md` for instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
bin/manage buildout2pip
command from plone/plone.releaser#72 to createmxsources.txt
andmxcheckouts.txt
from the Buildout sources and checkouts. Then we add some more files to use this, and update the Makefile:The Makefile targets starting with
pip
ormxdev
are new.Usage would be:
Some points of interest:
make pip-test
will need lots of changes before it can be a replacement ofbin/test
.mxdev
: it does not comment outPlone
andProducts.CMFPlone
from the constraints, probably because they have capital letters. I made a manual change inconstraints-mxdiv.txt
to work around this. I created an issue inmxdev
.pip install Products.CMFPlone
, with withPlone
, one withplone.volto
, and one withplone.classicui
. Tricky is that thePlone
package is always in the checkouts, so we would always have-e src/Plone
, making it hard to have a venv with onlyProducts.CMFPlone
. But the single venv with everything including test dependencies seems fine as a start.zope.conf
files, like cookieplone or other generators would do. That is for later. But maybe the ones generated by Buildout are fine for now.