Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolation problems fixed #183

Closed
wants to merge 1 commit into from
Closed

Isolation problems fixed #183

wants to merge 1 commit into from

Conversation

gforcada
Copy link
Sponsor Member

@gforcada gforcada commented Mar 1, 2016

Now that quite some test isolation problems have been fixed, maybe these two packages can get back to where they belong.

@gforcada gforcada force-pushed the no-longer-failing branch 2 times, most recently from f3253f5 to edf7cb3 Compare March 6, 2016 13:26
@gforcada gforcada mentioned this pull request Mar 7, 2016
Merged
mister-roboto pushed a commit that referenced this pull request May 26, 2016
@thet
[fc] Repository: icalendar
e7a27d6 
Branch: refs/heads/master
Date: 2016-02-17T08:28:40+01:00
Author: Stanislav Laznicka (stlaz) <slaznick@redhat.com>
Commit: collective/icalendar@4f845ce

Updated components to better conform to RFC 5545

collective/icalendar#176

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
Repository: icalendar
Branch: refs/heads/master
Date: 2016-05-26T10:52:46+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: collective/icalendar@640aa85

Merge pull request #183 from stlaz/rfc5545

Updated components to better conform to RFC 5545

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
mister-roboto pushed a commit that referenced this pull request May 26, 2016
@thet
[fc] Repository: icalendar
2898304 
Branch: refs/heads/master
Date: 2016-02-17T08:28:40+01:00
Author: Stanislav Laznicka (stlaz) <slaznick@redhat.com>
Commit: collective/icalendar@4f845ce

Updated components to better conform to RFC 5545

collective/icalendar#176

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
Repository: icalendar
Branch: refs/heads/master
Date: 2016-05-26T10:52:46+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: collective/icalendar@640aa85

Merge pull request #183 from stlaz/rfc5545

Updated components to better conform to RFC 5545

Files changed:
M CHANGES.rst
M src/icalendar/cal.py
@gforcada gforcada closed this Jun 15, 2016
@gforcada gforcada deleted the no-longer-failing branch June 15, 2016 19:55
@thet
Copy link
Member

thet commented Jun 15, 2016

@gforcada I'm curious - are there any other test isolation problems left? Does all go green with plone.testing 5.0 in place?

@gforcada
Copy link
Sponsor Member Author

Oh yes, there are plenty of them, LOTS of them actually, that's why tests.cfg is so complex, just take a look at it.

One step at a time though we can reduce that... by now unfortunately my focus is on jenkins and python 3.5 to be able to test the work done at Barcelona sprint.

mister-roboto pushed a commit that referenced this pull request Feb 10, 2019
@jensens
[fc] Repository: plone.app.upgrade
86d89ac 
Branch: refs/heads/master
Date: 2019-02-09T11:27:56+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@f94e497

Products.ResourceRegistries made conditional

Files changed:
A news/183.bugfix
M plone/app/upgrade/__init__.py
M plone/app/upgrade/tests/base.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v51/profiles/to_alpha1/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:12:43+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@c5f73fe

remove portal tools and configuration registry. testing

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_beta1/registry.xml
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@cb8e066

testing: imported and upgraded Plone 5.1 instance has no rr tools anymore

Files changed:
A plone/app/upgrade/v52/data/test-full-5_1.zexp
A plone/app/upgrade/v52/testing.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@fae9241

Tests removed for removal of legacy resource registries

Files changed:
M plone/app/upgrade/v52/tests.py
D plone/app/upgrade/v52/data/test-full-5_1.zexp
D plone/app/upgrade/v52/testing.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@56c8599

using utils

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T15:00:12+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@03febe6

getting closer to style guide. taking account of used version of p.a.registry

Files changed:
M plone/app/upgrade/__init__.py
M plone/app/upgrade/v42/final.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v52/alphas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T15:16:08+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@8d9bccd

skippping some tests for Plone 4

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T16:22:13+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@149808a

Kupu-Test only with existing legacy resource registries.

Files changed:
M plone/app/upgrade/v43/tests.py
M plone/app/upgrade/v52/alphas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T18:50:22+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@9d556cf

Skip only test not entire test suite

Files changed:
M plone/app/upgrade/v50/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T14:29:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@9567593

less test skipping on versions. clean up

Files changed:
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/betas.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T16:37:42+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@8dd4e29

Merge branch 'master' into remove-legacy-resource-registries-2

Files changed:
A news/195.bugfix
M plone/app/upgrade/v52/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T16:39:33+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@95b9e3f

Merge pull request #183 from plone/remove-legacy-resource-registries-2

Products.ResourceRegistries made conditional

Files changed:
A news/183.bugfix
M plone/app/upgrade/__init__.py
M plone/app/upgrade/tests/base.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v42/final.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v43/tests.py
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v51/profiles/to_alpha1/registry.xml
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/betas.py
M plone/app/upgrade/v52/profiles/to_beta1/registry.xml
M plone/app/upgrade/v52/tests.py
mister-roboto pushed a commit that referenced this pull request Feb 10, 2019
@jensens
[fc] Repository: plone.app.upgrade
7f709a8 
Branch: refs/heads/master
Date: 2019-02-09T11:27:56+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@f94e497

Products.ResourceRegistries made conditional

Files changed:
A news/183.bugfix
M plone/app/upgrade/__init__.py
M plone/app/upgrade/tests/base.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v51/profiles/to_alpha1/registry.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:12:43+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@c5f73fe

remove portal tools and configuration registry. testing

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/profiles/to_beta1/registry.xml
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@cb8e066

testing: imported and upgraded Plone 5.1 instance has no rr tools anymore

Files changed:
A plone/app/upgrade/v52/data/test-full-5_1.zexp
A plone/app/upgrade/v52/testing.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@fae9241

Tests removed for removal of legacy resource registries

Files changed:
M plone/app/upgrade/v52/tests.py
D plone/app/upgrade/v52/data/test-full-5_1.zexp
D plone/app/upgrade/v52/testing.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T12:15:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@56c8599

using utils

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T15:00:12+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@03febe6

getting closer to style guide. taking account of used version of p.a.registry

Files changed:
M plone/app/upgrade/__init__.py
M plone/app/upgrade/v42/final.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v52/alphas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T15:16:08+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@8d9bccd

skippping some tests for Plone 4

Files changed:
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T16:22:13+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@149808a

Kupu-Test only with existing legacy resource registries.

Files changed:
M plone/app/upgrade/v43/tests.py
M plone/app/upgrade/v52/alphas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-09T18:50:22+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@9d556cf

Skip only test not entire test suite

Files changed:
M plone/app/upgrade/v50/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T14:29:44+01:00
Author: Katja Süss (ksuess) <k.suess@rohberg.ch>
Commit: plone/plone.app.upgrade@9567593

less test skipping on versions. clean up

Files changed:
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/betas.py
M plone/app/upgrade/v52/tests.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T16:37:42+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@8dd4e29

Merge branch 'master' into remove-legacy-resource-registries-2

Files changed:
A news/195.bugfix
M plone/app/upgrade/v52/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-10T16:39:33+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@95b9e3f

Merge pull request #183 from plone/remove-legacy-resource-registries-2

Products.ResourceRegistries made conditional

Files changed:
A news/183.bugfix
M plone/app/upgrade/__init__.py
M plone/app/upgrade/tests/base.py
M plone/app/upgrade/v40/alphas.py
M plone/app/upgrade/v42/final.py
M plone/app/upgrade/v42/profiles/to_422/registry.xml
M plone/app/upgrade/v43/profiles/to_alpha2/registry.xml
M plone/app/upgrade/v43/tests.py
M plone/app/upgrade/v50/profiles/to_alpha3/registry.xml
M plone/app/upgrade/v50/testing.py
M plone/app/upgrade/v50/tests.py
M plone/app/upgrade/v51/profiles/to_alpha1/registry.xml
M plone/app/upgrade/v52/alphas.py
M plone/app/upgrade/v52/betas.py
M plone/app/upgrade/v52/profiles/to_beta1/registry.xml
M plone/app/upgrade/v52/tests.py
mister-roboto pushed a commit that referenced this pull request Jun 20, 2019
@agitator
[fc] Repository: plonetheme.barceloneta
638aab6 
Branch: refs/heads/master
Date: 2019-06-20T14:51:13+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plonetheme.barceloneta@5334b4f

Allow long photoAlbumEntryTitle entries to break to fit width.

Files changed:
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
M plonetheme/barceloneta/theme/less/thumbs.plone.less
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2019-06-20T14:52:25+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plonetheme.barceloneta@7ae924e

add news

Files changed:
A news/183.bugfix
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2019-06-20T23:53:52+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: plone/plonetheme.barceloneta@316dcf6

Merge pull request #183 from plone/photoentrytitlefix

Allow long photoAlbumEntryTitle entries to break to fit width.

Files changed:
A news/183.bugfix
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
M plonetheme/barceloneta/theme/less/thumbs.plone.less
mister-roboto pushed a commit that referenced this pull request Jun 20, 2019
@agitator
[fc] Repository: plonetheme.barceloneta
44803ab 
Branch: refs/heads/master
Date: 2019-06-20T14:51:13+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plonetheme.barceloneta@5334b4f

Allow long photoAlbumEntryTitle entries to break to fit width.

Files changed:
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
M plonetheme/barceloneta/theme/less/thumbs.plone.less
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2019-06-20T14:52:25+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plonetheme.barceloneta@7ae924e

add news

Files changed:
A news/183.bugfix
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2019-06-20T23:53:52+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: plone/plonetheme.barceloneta@316dcf6

Merge pull request #183 from plone/photoentrytitlefix

Allow long photoAlbumEntryTitle entries to break to fit width.

Files changed:
A news/183.bugfix
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
M plonetheme/barceloneta/theme/less/thumbs.plone.less
mister-roboto pushed a commit that referenced this pull request Jun 11, 2020
@mauritsvanrees
[fc] Repository: plone.app.theming
d3b8b09 
Branch: refs/heads/master
Date: 2020-06-10T23:05:22+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@64f4fec

Added test for saving the advanced control panel.

This should help surface some `WrongType`  exceptions.

Files changed:
M src/plone/app/theming/tests/test_controlpanel.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-10T23:07:58+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@865d37b

Revert "Do not call processInputs."

This reverts commit dd4f7fc15d1d7ec890780b1f64ad433efaf4fb9e.

Files changed:
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-10T23:17:02+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@12e382f

Import processInputs conditionally.

Files changed:
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-10T23:21:40+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@e6d07c7

Do not make a string from custom_css.

The field is SourceText, which is unicode on Python 2, and str on Python 3.
So on Python 2, creating a string of it results in a WrongType error.
See plone/plone.app.theming#183

Files changed:
M src/plone/app/theming/browser/controlpanel.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-10T23:28:43+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@9c64d46

Revert "fix hostnameBlacklist (Theming ControlPanel) in Py3"

This reverts commit d6db78dbb930837c296aae87cea16bacde391a9b.

No longer needed after calling processInputs.

Files changed:
M src/plone/app/theming/browser/controlpanel.pt
M src/plone/app/theming/browser/controlpanel.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-10T23:38:32+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@5cb479c

Added changelog entry for #183 fix.

Files changed:
A news/183.bugfix
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-11T10:11:25+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@a360731

Added upgrade step to reload the theming registry.

Otherwise when you upgrade from Plone 5.2.1, and try to save the theming control panel, you get an error:

```
Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 162, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 359, in publish_module
  Module ZPublisher.WSGIPublisher, line 262, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 63, in call_object
  Module plone.app.theming.browser.controlpanel, line 65, in __call__
  Module plone.app.theming.browser.controlpanel, line 215, in update
  Module plone.registry.recordsproxy, line 59, in __setattr__
AttributeError: custom_css_timestamp
```

Files changed:
M src/plone/app/theming/configure.zcml
M src/plone/app/theming/profiles/default/metadata.xml
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2020-06-11T20:31:42+02:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.app.theming@fdbb576

Merge pull request #184 from plone/maurits/issue-183-save-advanced-controlpanel-wrongtype

Call processInputs when available, fixing WrongType

Files changed:
A news/183.bugfix
M src/plone/app/theming/browser/controlpanel.pt
M src/plone/app/theming/browser/controlpanel.py
M src/plone/app/theming/browser/mapper.py
M src/plone/app/theming/configure.zcml
M src/plone/app/theming/profiles/default/metadata.xml
M src/plone/app/theming/tests/test_controlpanel.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gforcada @thet