Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test isolation problems #179

Closed
wants to merge 1 commit into from
Closed

Test isolation problems #179

wants to merge 1 commit into from

Conversation

gforcada
Copy link
Sponsor Member

plone.testing 5.0 raises an error if a test in an integration test tries to make a commit, which would lead to test isolation problems.

Check how many packages need to be fixed, since quite a few were already fixed.

Not sure if we want to bump plone.testing version in versions.cfg though, as that could lead to client buildout breaking with a minor update... OTOH if we never push it in nobody will be able to fix their own isolation problems either... comments? @plone/framework-team @plone/release-team

@tisto
Copy link
Sponsor Member

tisto commented Feb 22, 2016

@gforcada that's actually quite good news! The test isolations problems are just in p.a.linkintegrity and one test in plone.app.layout.

@pbauer you refactored the p.a.linkintegrity tests lately, right? Would you mind having a look?

@gforcada
Copy link
Sponsor Member Author

There were only errors on plone.app.linkintegrity and plone.app.layout.

Pull requests have been created and jenkins is furiously running them, if both are ok, we can run once more this pull request and see if everything is solved already!

@gforcada
Copy link
Sponsor Member Author

gforcada commented Mar 1, 2016

Both pull requests passed and are merged, running jenkins again here to see if everything has been fixed :-)

@gforcada
Copy link
Sponsor Member Author

gforcada commented Mar 1, 2016

So there are still some errors (although jenkins fails to show them): http://jenkins.plone.org/job/pull-request-5.0/1010/console

@thet
Copy link
Member

thet commented Mar 1, 2016

@gforcada
In the plone-zope4.cfg PLIP buildout, where we depend also on latest plone.testing, we get these errors reported: http://jenkins.plone.org/view/PLIPs/job/plip-zope4/30/testReport/
68 failures, but -38 after your last isolation fixes.

@thet thet mentioned this pull request Mar 2, 2016
Closed
5 tasks
jensens added a commit that referenced this pull request Mar 11, 2016
@jensens
update plone.testing to 5.0.0 like in #179
e2b0ac4
@jensens jensens mentioned this pull request Mar 11, 2016
Closed
@gforcada
Copy link
Sponsor Member Author

Closing in favor of #194

@gforcada gforcada closed this Mar 12, 2016
@gforcada gforcada deleted the gforcada-patch-2 branch March 12, 2016 13:29
gforcada pushed a commit that referenced this pull request Sep 11, 2016
@jensens @gforcada
update plone.testing to 5.0.0 like in #179
0100a2c
jensens added a commit that referenced this pull request Oct 3, 2016
@jensens
update plone.testing to 5.0.0 like in #179
695a5d8
jensens added a commit that referenced this pull request Oct 23, 2016
@jensens
update plone.testing to 5.0.0 like in #179
f134f40
jensens added a commit that referenced this pull request Nov 9, 2016
@jensens
update plone.testing to 5.0.0 like in #179
b77f763
mister-roboto pushed a commit that referenced this pull request Oct 3, 2018
@ale-rt
[fc] Repository: plone.app.upgrade
c54d3b0 
Branch: refs/heads/master
Date: 2018-10-03T10:19:41+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@78fb4ae

Do not break if archetypes are not available

Fixes #178

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T13:47:16+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.upgrade@1323207

skip upgrade-step removeLargePloneFolder when there is no portal_factory

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:13:16+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@46d325c

Gracefully fail if plone.app.blobs is missing

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:14:07+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@dc8d48b

Update changelog

Files changed:
M news/178.bugfix
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T17:12:12+02:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@a90a0fe

Merge pull request #179 from plone/python3

Do not break if archetypes are not available

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
mister-roboto pushed a commit that referenced this pull request Oct 3, 2018
@ale-rt
[fc] Repository: plone.app.upgrade
ce3cb1d 
Branch: refs/heads/master
Date: 2018-10-03T10:19:41+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@78fb4ae

Do not break if archetypes are not available

Fixes #178

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T13:47:16+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.upgrade@1323207

skip upgrade-step removeLargePloneFolder when there is no portal_factory

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:13:16+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@46d325c

Gracefully fail if plone.app.blobs is missing

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:14:07+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@dc8d48b

Update changelog

Files changed:
M news/178.bugfix
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T17:12:12+02:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@a90a0fe

Merge pull request #179 from plone/python3

Do not break if archetypes are not available

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
mister-roboto pushed a commit that referenced this pull request Oct 3, 2018
@ale-rt
[fc] Repository: plone.app.upgrade
a1d45b5 
Branch: refs/heads/master
Date: 2018-10-03T10:19:41+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@78fb4ae

Do not break if archetypes are not available

Fixes #178

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T13:47:16+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.upgrade@1323207

skip upgrade-step removeLargePloneFolder when there is no portal_factory

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:13:16+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@46d325c

Gracefully fail if plone.app.blobs is missing

Files changed:
M plone/app/upgrade/v40/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T16:14:07+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@dc8d48b

Update changelog

Files changed:
M news/178.bugfix
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2018-10-03T17:12:12+02:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.upgrade@a90a0fe

Merge pull request #179 from plone/python3

Do not break if archetypes are not available

Files changed:
A news/178.bugfix
M plone/app/upgrade/v40/betas.py
D plone/app/upgrade/v40/profiles/to_beta4/types/File.xml
D plone/app/upgrade/v40/profiles/to_beta4/types/Image.xml
mister-roboto pushed a commit that referenced this pull request Feb 7, 2019
@gforcada
[fc] Repository: plone.app.layout
2b39fa6 
Branch: refs/heads/master
Date: 2019-02-06T21:39:24+01:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.layout@0c90d14

Remove unnecessary line

Refs. #2516

Files changed:
M plone/app/layout/navigation/navtree.py
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2019-02-07T12:11:48+01:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.layout@d059d3d

Merge branch 'master' into 2516-fixup-2

Files changed:
M CHANGES.rst
M plone/app/layout/navigation/navtree.py
M plone/app/layout/viewlets/tests/test_common.py
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2019-02-07T12:16:24+01:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.layout@91634f7

Merge branch 'master' into 2516-fixup-2

Files changed:
M plone/app/layout/navigation/navtree.py
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2019-02-07T14:38:57+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.layout@138f941

Merge pull request #179 from plone/2516-fixup-2

Remove unnecessary line

Files changed:
M plone/app/layout/navigation/navtree.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gforcada @tisto @thet @jensens