feat: Pass all data attributes through to image block (#34)

plone · Sep 6, 2023 · 1bc9aff · 1bc9aff
1 parent 30f5e11
commit 1bc9aff
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/converters/blocks.js b/src/converters/blocks.js
@@ -22,10 +22,6 @@ const imageBlock = (elem, href) => {
     ];
   }
 
-  if (elem.dataset.href != null) {
-    block.href = elem.dataset.href;
-  }
-
   switch (alignFromClassName(elem.className)) {
     case 'left':
       block.align = 'left';
@@ -56,6 +52,12 @@ const imageBlock = (elem, href) => {
         break;
     }
   }
+
+  // pass through data attributes to block data
+  for (const [k, v] of Object.entries(elem.dataset)) {
+    block[k] = v;
+  }
+
   return block;
 };
 

diff --git a/src/converters/blocks.test.js b/src/converters/blocks.test.js
@@ -80,4 +80,12 @@ describe('imageBlock processing', () => {
       '../resolveuid/7c6a1b0a0d2f40ffb6a4c73fd67b185d',
     );
   });
+  test('Image with data attributes', () => {
+    const elem = elementFromString(
+      '<img src="../resolveuid/7c6a1b0a0d2f40ffb6a4c73fd67b185d" title="A Picture" alt="Picture of a person" data-align="wide">',
+    );
+    const result = imageBlock(elem);
+    expect(result['@type']).toBe('image');
+    expect(result['align']).toBe('wide');
+  });
 });