generate-metadata.SemanticVersion - update to include 'build' portion #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of semvar in container image tags using '_' instead of '+' since '+' isn't supported by container image tag syntax but not having the 'build' porition of the version on the tag can cause tags to unexpectadly get overwritten/lost if major.minor.patch isn't updated by applciation devs
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 3948 3949 +1
=========================================
+ Hits 3948 3949 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
christophermay07
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
generate-metadata.SemanticVersion - update to include 'build' portion of semvar in container image tags using '_' instead of '+' since '+' isn't supported by container image tag syntax but not having the 'build' porition of the version on the tag can cause tags to unexpectedly get overwritten/lost if major.minor.patch isn't updated by application devs
Breaking?
No
Integration Testing
TODO