Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD - make it smart enough to handle an Applciation that goes into Degraded state while waiting for it to go Healthy state #244

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Nov 5, 2021

Purpose

sometimes when wiating for ArgoCD Applciation to become Healthy after a Sync the Applciation will actually get MORE Degraded, like from a Deployment rolling out and then a HorizontalPodAutoscaller then becoming degraded mid waiting for Healthy. Need to make PSR smarter to handle this case.

Breaking?

No

Integration Testing

tested in private integration environment with use case that was consitently failing and now is working.

… Degraded state while waiting for it to go Healthy state
@itewk itewk self-assigned this Nov 5, 2021
@itewk itewk added the enhancement New feature or request label Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #244 (65fe659) into main (31ab347) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         3864      3879   +15     
=========================================
+ Hits          3864      3879   +15     
Flag Coverage Δ
pytests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._runner/step_implementers/shared/argocd_generic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ab347...65fe659. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant