Refactored the code that parses Maven surefire XML files

[dwinchell]

Purpose

This is a refactor that does not change functionality. The code for parsing Maven surefire XML was complex. I replaced it with something less complex.

(I originally intended to fix a bug that I didn't know was already fixed by #233.)

Breaking?

No

Integration Testing

minimal - https://jenkins-jenkins.apps.tssc.rht-set.com/job/Ploigos%20Reference%20Applciations%20(minimal)/job/reference-quarkus-mvn/view/change-requests/job/PR-63/
typical - https://jenkins-jenkins.apps.tssc.rht-set.com/job/Ploigos%20Reference%20Applciations%20(typical)/job/reference-quarkus-mvn/view/change-requests/job/PR-63/
everything - https://jenkins-jenkins.apps.tssc.rht-set.com/job/Ploigos%20Reference%20Applciations%20(everything)/job/reference-quarkus-mvn/view/change-requests/job/PR-63/

[itewk]

@dwinchell i think you are fixing something that is already fixed by #233 hence the merge conflicts...

[codecov]

Codecov Report

Merging #240 (0dfc52e) into main (c630d15) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0dfc52e differs from pull request most recent head c9d74f0. Consider uploading reports for the commit c9d74f0 to get more accurate results

@@            Coverage Diff            @@
##              main      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         3870      3850   -20     
=========================================
- Hits          3870      3850   -20     

Flag	Coverage Δ
pytests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/ploigos_step_runner/utils/xml.py	100.00% <ø> (ø)
..._implementers/shared/maven_test_reporting_mixin.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c630d15...c9d74f0. Read the comment docs.

[dwinchell]

Integration testing is blocked because the credentials for the Nexus service account that we have checked into git (encrypted w/ sops) are not working ... I asked in ploigos chat and I'm going to reset it tomorrow if I don't hear a reason not to.

Error is here https://jenkins-jenkins.apps.tssc.rht-set.com/job/Ploigos%20Reference%20Applciations%20(minimal)/job/reference-quarkus-mvn/job/main/16/console

Also see http://gitea.tssc.rht-set.com/ploigos-reference-applications/reference-quarkus-mvn/src/branch/main/cicd/ploigos-integration-environment/shared/typical/ploigos-step-runner-config/config-secrets.yml

[dwinchell]

The code is done, assuming the integration tests pass when i fix the above unrelated problem with them.

[itewk]

@dwinchell this seems to get rid of abillity to collect non numeric values in a list, why?

[dwinchell]

@dwinchell this seems to get rid of abillity to collect non numeric values in a list, why?

@itewk because we don't use that ability, probably never will, and it the code is simpler if we leave it out in the rewritten version.

The original version was complex (pylint agrees) in part because it tried to be so reusable. But that complexity made it expensive to maintain (we're having this conversation). The new version is simpler at the cost of planning for less reuse.

[dwinchell]

Integration tests passed

[itewk]

@dwinchell

@dwinchell this seems to get rid of abillity to collect non numeric values in a list, why?

@itewk because we don't use that ability, probably never will, and it the code is simpler if we leave it out in the rewritten version.

The original version was complex (pylint agrees) in part because it tried to be so reusable. But that complexity made it expensive to maintain (we're having this conversation). The new version is simpler at the cost of planning for less reuse.

okay. good enough for me.