Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_metadata.Jenkins - init add #231

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Oct 18, 2021

Purpose

add a generate-metadata StepImplementer for Jenkins.

Dependencies

This is useless without #230 which is what expects the workflow-run-num config value.

Breaking?

No

Integration Testing

Tested with internal app.

@itewk itewk self-assigned this Oct 18, 2021
@itewk itewk added the enhancement New feature or request label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #231 (bcac6ad) into main (a2cdfff) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bcac6ad differs from pull request most recent head 502c2e3. Consider uploading reports for the commit 502c2e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           92        93    +1     
  Lines         3808      3824   +16     
=========================================
+ Hits          3808      3824   +16     
Flag Coverage Δ
pytests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/step_implementers/generate_metadata/__init__.py 100.00% <100.00%> (ø)
...ner/step_implementers/generate_metadata/jenkins.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cdfff...502c2e3. Read the comment docs.

dwinchell
dwinchell previously approved these changes Oct 18, 2021
@itewk
Copy link
Contributor Author

itewk commented Oct 18, 2021

rebased on main. no other changes. assuming @dwinchell 's aproval still stands.

@itewk itewk merged commit c77235c into ploigos:main Oct 18, 2021
@itewk itewk deleted the feature/gen-meta-jenkins branch October 18, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants