Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tox generic and tox unit test step implementer #223

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Sep 27, 2021

NOTE

replaces #219 with clean history

Purpose

Adding python tox generic and python tox unit test step implementer.

Breaking?

No

Integration Testing

Tested a local python tox test environment command execution to confirm the tests ran succesfully against the tox.ini configuration file.

  • Tox generic makes no assumption about installed packages or commands defined in the tox.ini. It simply calls the target tox environment defined in the tox_env configuration parameter and executes the associated .ini config.
  • The tox unit-test step implementer defaults to test for the tox_env parameter.

@itewk itewk mentioned this pull request Sep 27, 2021
@itewk itewk added the enhancement New feature or request label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #223 (89c175c) into main (14ee488) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           84        87    +3     
  Lines         3479      3556   +77     
=========================================
+ Hits          3479      3556   +77     
Flag Coverage Δ
pytests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tep_runner/step_implementers/shared/tox_generic.py 100.00% <100.00%> (ø)
...tep_runner/step_implementers/unit_test/__init__.py 100.00% <100.00%> (ø)
...tep_runner/step_implementers/unit_test/tox_test.py 100.00% <100.00%> (ø)
src/ploigos_step_runner/utils/tox.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ee488...89c175c. Read the comment docs.

@itewk itewk merged commit 9cbffa0 into ploigos:main Sep 27, 2021
@itewk itewk deleted the feature/tox branch September 27, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants