Skip to content

Commit

Permalink
Merge pull request #268 from plivo/SMS-6047
Browse files Browse the repository at this point in the history
SMS-6047 made meta object consistent for P2 APIs
  • Loading branch information
kanishka2104 authored Feb 7, 2024
2 parents a393abe + ab25018 commit 48931e1
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [5.38.2](https://github.com/plivo/plivo-java/tree/v5.38.2) (2024-01-15)
**Feature - Made meta object consistent for List Powerpacks, List Media, List Numbers, List Shortcodes, List Tollfree API**
- Made meta object consistent in API response

## [5.38.1](https://github.com/plivo/plivo-java/tree/v5.38.1) (2023-12-19)
**Feature - Added params for Speak API**
- Added params 'type' for Speak APIs
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If you are using Maven, use the following XML to include the Plivo SDK as a depe
<dependency>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.38.1</version>
<version>5.38.2</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion pom.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Written manually.

version=5.38.1
version=5.38.2
groupId=com.plivo
artifactId=plivo-java

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.38.1</version>
<version>5.38.2</version>
<name>plivo-java</name>
<description>A Java SDK to make voice calls &amp; send SMS using Plivo and to generate Plivo XML</description>
<licenses>
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/plivo/api/models/base/Meta.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import java.lang.NoSuchMethodException;

@JsonInclude(JsonInclude.Include.NON_NULL)
public class Meta {

protected Long limit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public String getId() {

public String getNumberPoolId() {
String[] numberpool_uuid = getNumber_pool().split("/");
return numberpool_uuid[5];
return (numberpool_uuid.length > 5) ? numberpool_uuid[5] : null;
}

}
4 changes: 4 additions & 0 deletions src/main/java/com/plivo/api/models/powerpack/Shortcode.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ public class Shortcode extends BaseResource {
public Shortcode(String uuid) {
this.uuid = uuid;
}

public Shortcode() {
//Introducing the dummy constructor
}

@JsonIgnore
public Shortcode getter() {
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/com/plivo/api/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.38.1
5.38.2

0 comments on commit 48931e1

Please sign in to comment.