add Renderer::getClearOptions (google#7272)

FIXES=[243846268]
plepers · Dec 9, 2023 · ad4fabb · ad4fabb
1 parent 126aa72
commit ad4fabb
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 0 deletions.
diff --git a/NEW_RELEASE_NOTES.md b/NEW_RELEASE_NOTES.md
@@ -14,4 +14,5 @@ appropriate header in [RELEASE_NOTES.md](./RELEASE_NOTES.md).
 - engine: New tone mapper: `AgXTonemapper`.
 - matinfo: Add support for viewing ESSL 1.0 shaders
 - engine: Add support for stencil buffer when post-processing is disabled (Metal backend only).
+- engine: Add `Renderer::getClearOptions()` [b/243846268]
 - engine: Fix stable shadows (again) when an IBL rotation is used
diff --git a/filament/include/filament/Renderer.h b/filament/include/filament/Renderer.h
@@ -173,6 +173,12 @@ class UTILS_PUBLIC Renderer : public FilamentAPI {
      */
     void setClearOptions(const ClearOptions& options);
 
+    /**
+     * Returns the ClearOptions currently set.
+     * @return A reference to a ClearOptions structure.
+     */
+    ClearOptions const& getClearOptions() const noexcept;
+
     /**
      * Get the Engine that created this Renderer.
      *

diff --git a/filament/src/Renderer.cpp b/filament/src/Renderer.cpp
@@ -81,6 +81,10 @@ void Renderer::setClearOptions(const ClearOptions& options) {
     downcast(this)->setClearOptions(options);
 }
 
+Renderer::ClearOptions const& Renderer::getClearOptions() const noexcept {
+    return downcast(this)->getClearOptions();
+}
+
 void Renderer::renderStandaloneView(View const* view) {
     downcast(this)->renderStandaloneView(downcast(view));
 }

diff --git a/filament/src/details/Renderer.h b/filament/src/details/Renderer.h
@@ -127,6 +127,10 @@ class FRenderer : public Renderer {
         mClearOptions = options;
     }
 
+    ClearOptions const& getClearOptions() const noexcept {
+        return mClearOptions;
+    }
+
 private:
     friend class Renderer;
     using Command = RenderPass::Command;

diff --git a/web/filament-js/jsbindings.cpp b/web/filament-js/jsbindings.cpp
@@ -612,6 +612,7 @@ class_<Renderer>("Renderer")
         engine->execute();
     }), allow_raw_pointers())
     .function("_setClearOptions", &Renderer::setClearOptions, allow_raw_pointers())
+    .function("getClearOptions", &Renderer::getClearOptions)
     .function("beginFrame", EMBIND_LAMBDA(bool, (Renderer* self, SwapChain* swapChain), {
         return self->beginFrame(swapChain);
     }), allow_raw_pointers())