fix!: Distinguish between "Pleo" env and Github env in deployment #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macko911
force-pushed
the
web-1557-fix-dummy-app-productionstaging-deploys
branch
from
e4d6feb to
9d5e183
Compare
macko911
changed the title
tkloht
changed the title
tkloht
approved these changes
Oct 28, 2024
mortenbroesby
deleted the
web-1557-fix-dummy-app-productionstaging-deploys
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following deploy error https://github.com/pleo-io/product-web/actions/runs/11483548110/job/31959328063
Currently it is expected that the name of Github environment we deploy to matches one of the "Pleo" environments as we define them in the Environment type
This is problematic for the spa-config-inject script which uses the name of the Github environment to find the appropriate config file.
We can't deploy multiple apps from one repo to the same Github environment.