Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JATS 1.3 for v1.0 release #41

Closed
tcatapano opened this issue Mar 20, 2019 · 5 comments
Closed

Use JATS 1.3 for v1.0 release #41

tcatapano opened this issue Mar 20, 2019 · 5 comments
Assignees
Milestone

Comments

@tcatapano
Copy link
Member

Seems like a good idea

@tcatapano tcatapano added this to the v1.0 milestone Mar 20, 2019
@tcatapano tcatapano self-assigned this Mar 20, 2019
@tcatapano
Copy link
Member Author

With the release of JATS 1.3, it should be used for the next release.

@tcatapano tcatapano changed the title Use JATS 1.2 for v1.0 release Use JATS 1.3 for v1.0 release Jan 30, 2023
@tcatapano
Copy link
Member Author

tcatapano commented Jan 31, 2023

getting this validity error from xmllint:

xmllint --load-trace --valid samples/test_tp1-3.xml

Loaded URL="JATS-common1-3.ent" ID="-//NLM//DTD JATS (Z39.96) JATS DTD Suite Common (Shared) Elements Module v1.3 20210610//EN"
JATS-common1-3.ent:3382: validity error : Definition of mixed-citation has duplicate references to string-date
                        (#PCDATA | %citation-elements;)*             >
--

not sure if this is significant or an issue with base JATS as opposed to TaxPub. Will run xmllint on JATS 1.3 dtd to check

@tcatapano
Copy link
Member Author

tcatapano commented Jan 31, 2023

xerces in oXygen reports this:

System ID: /Users/thc4/Github/TaxPub/JATS-common1-3.ent
Main validation file: /Users/thc4/Github/TaxPub/samples/test_tp1-3.xml
Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: Xerces
Severity: error
Problem ID: DuplicateTypeInMixedContent
Description: The element type "string-date" was already specified in the content model of the element decl "mixed-citation".
Start location: 3381:55

@tcatapano
Copy link
Member Author

xmllint in oXygen does not report the "DuplicateTypeInMixedContent" error, though it does report a number of errors relating to duplicate deifnitions of attributes:

Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: LIBXML
Severity: error
Description:  validity warning : Attribute base of element tp:type-genus: already defined
Start location: 172:0
--
Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: LIBXML
Severity: error
Description:  validity warning : Attribute actuate of element tp:descriptive-statement: already defined
Start location: 270:0
--
Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: LIBXML
Severity: error
Description:  validity warning : Attribute base of element tp:descriptive-statement: already defined
Start location: 282:0
--
Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: LIBXML
Severity: error
Description:  validity warning : Attribute base of element tp:descriptive-statement: already defined
Start location: 293:0
--
Schema: /Users/thc4/Github/TaxPub/tax-treatment-NS0-v1.dtd
Engine name: LIBXML
Severity: error
Description:  validity warning : Attribute base of element tp:descriptive-statement: already defined
Start location: 307:0

@tcatapano
Copy link
Member Author

Implemented. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant