Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting the tutorial island guide to focus on Redstone #1414

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Adapting the tutorial island guide to focus on Redstone #1414

merged 4 commits into from
Jul 29, 2024

Conversation

ldunnplaymint
Copy link
Contributor

No description provided.

@ldunnplaymint
Rewrite advanced tutorials to focus redstone
22b7c35 
Link the advanced tutorials from the end of the Redstone Guide

Fix a link

Tutorial 1 first pass

Section Numbers

Update tut 2

Fixing a link

Clean up the reference doc

Update tutorial 3

Update tutorial 4

Update Tutorial 5

Spelling

Fix a link

Update tutorial 6

Final deploy step on tut 6

Modify tut 7

Add tutorial 7 to the tutorial list
@5p0rt5BEArD 5p0rt5BEArD self-requested a review July 24, 2024 09:56
5p0rt5BEArD
5p0rt5BEArD previously requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@5p0rt5BEArD 5p0rt5BEArD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff
Only a couple of change requests
A future task I think is to combine the redstoneguide with tutorial one because they overlap.

contracts/src/maps/tutorial-room-2/README.md Outdated Show resolved Hide resolved
tutorial/REFERENCE.md Outdated Show resolved Hide resolved
@ldunnplaymint
Copy link
Contributor Author

Good stuff Only a couple of change requests A future task I think is to combine the redstoneguide with tutorial one because they overlap.

Yeah, you are right. I wrote it like this because the milestone goal only goes as far as deploying tiles. I wanted to then get ahead of myself and re-write everything else because I think we just will end up doing so anyway!

ldunnplaymint
ldunnplaymint commented Jul 29, 2024
View reviewed changes
Copy link
Contributor Author

@ldunnplaymint ldunnplaymint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@ldunnplaymint ldunnplaymint dismissed 5p0rt5BEArD’s stale review July 29, 2024 15:33

Approved by farms

@ldunnplaymint ldunnplaymint merged commit 661169f into main Jul 29, 2024
3 checks passed
@ldunnplaymint ldunnplaymint deleted the advanced-tut-rs branch July 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfarms chrisfarms chrisfarms approved these changes

@5p0rt5BEArD 5p0rt5BEArD 5p0rt5BEArD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldunnplaymint @chrisfarms @5p0rt5BEArD