Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs2 upgrade #8929

Merged
merged 1 commit into from
Jan 18, 2019
Merged

specs2 upgrade #8929

merged 1 commit into from
Jan 18, 2019

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jan 10, 2019

Has been published now for Scala 2.13.0-M5:
etorreborre/specs2#709 (comment)

@mkurz
Copy link
Member Author

mkurz commented Jan 10, 2019

I don't know why, but typesafe-cla-validator does not respond here.

@octonato octonato added this to the Play 2.7.0 milestone Jan 10, 2019
@dwijnand dwijnand removed this from the Play 2.7.0 milestone Jan 11, 2019
@mkurz
Copy link
Member Author

mkurz commented Jan 15, 2019

@renatocaval I guess this should be in 2.7.x as well, because if we introduce Scala 2.13 support in Play 2.7 we would have to upgrade specs2 anyway, or not?

@octonato
Copy link
Contributor

@mkurz I would wait with this one as this is not on the critical path now.

We can update Specs in 2.7.0 and we start to support 2.13.

@mkurz
Copy link
Member Author

mkurz commented Jan 15, 2019

That's ok with me.

Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Matthias.

As Renato said, we can later update it in 2.7.x since this is a minor release.

@mkurz
Copy link
Member Author

mkurz commented Jan 15, 2019

lightbend-cla-validator is green now after closing/re-opening the pull request...

@mkurz mkurz added this to the Play 2.7.x milestone Jan 17, 2019
@dwijnand dwijnand merged commit 6e44e34 into playframework:master Jan 18, 2019
@mkurz mkurz deleted the specs2-4.3.6 branch January 18, 2019 19:51
dwijnand pushed a commit to dwijnand/playframework that referenced this pull request Jan 30, 2019
(cherry picked from commit 6e44e34)
@mkurz
Copy link
Member Author

mkurz commented Jan 30, 2019

Backported to 2.7.x via #8998

@mkurz mkurz modified the milestones: Play 2.7.x, Play 2.7.0 Jan 30, 2019
@dwijnand dwijnand modified the milestones: Play 2.7.0, Play 2.8.0-M1 May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants