-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--sync
should be a default option for play deps
#983
Comments
Agree |
@xael-fry It seems that everyone is agree. What do you think? |
Ok we can do it, and maybe add a |
…ON by default. [playframework#983] feat(DependenciesManager): add new option "nosync"
…ON by default. [playframework#983] feat(DependenciesManager): add new option "nosync"
[#983] feat(DependenciesManager): sync option should be ON by default.
Merged in 1.4.x with PR 1076. |
I used to put my external jars in libs. Now, they are scrubbed when I run |
@daohodac you can use |
Yes, I also think that adding your lib in dependencies.yml is a right
option.
Andrei Solntsev
2017-03-13 12:08 GMT+02:00 Alexandre Chatiron <notifications@github.com>:
… @daohodac <https://github.com/daohodac> you can use --nosync to avoid
removing the lib, on you can add your lib in dependencies.yml
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#983 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARE3asdhxSXL6P-fEoD4U55x6IOGDU2ks5rlRWlgaJpZM4I-qwK>
.
|
How can I add the lib in dependencies.yml? I assume that I have a folder in my play application, say "custom-deps" with several jars. How can I add this ref in the dependencies.yml? thank's! |
@daohodac See https://github.com/codeborne/play-pdf/ for example. You need to declate in dependencies.yml:
|
Thank's Andrei, it worked like a charm. and now I stick to the best practice
Dao Hodac
…On Mon, Mar 13, 2017 at 4:45 PM, Andrei Solntsev ***@***.***> wrote:
@daohodac <https://github.com/daohodac> See https://github.com/codeborne/
play-pdf/ for example.
You need to declate in dependencies.yml:
require:
- local-jar -> flying-saucer-core-cbpatched latest.integration
- local-jar -> flying-saucer-pdf-cbpatched latest.integration
repositories:
- local-jars:
type: local
artifact: ${application.path}/jars/[module].jar
contains:
- local-jar -> *
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#983 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA21WZ0O2L24rVGrKiZRbfVUHE2OpOSkks5rlWSBgaJpZM4I-qwK>
.
|
I believe that the command
play deps
without--sync
option is absolutely useless.You always need to delete old dependencies when you are downloading new dependencies.
Otherwise you will have duplicate dependencies in the application.
In our projects, we always write
play deps --sync
which is just boring.I suggest that
--sync
should be ON by default.The text was updated successfully, but these errors were encountered: