Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--sync should be a default option for play deps #983

Closed
asolntsev opened this issue Jun 26, 2016 · 10 comments
Closed

--sync should be a default option for play deps #983

asolntsev opened this issue Jun 26, 2016 · 10 comments
Assignees
Milestone

Comments

@asolntsev
Copy link
Contributor

I believe that the command play deps without --sync option is absolutely useless.
You always need to delete old dependencies when you are downloading new dependencies.
Otherwise you will have duplicate dependencies in the application.

In our projects, we always write play deps --sync which is just boring.

I suggest that --sync should be ON by default.

@tazmaniax
Copy link
Collaborator

Agree

@asolntsev asolntsev added this to the 1.4.4 milestone Oct 15, 2016
@asolntsev asolntsev self-assigned this Dec 29, 2016
@asolntsev
Copy link
Contributor Author

@xael-fry It seems that everyone is agree. What do you think?

@xael-fry
Copy link
Member

Ok we can do it, and maybe add a --nosync option, so all users will be able to choose the behavior they want

xael-fry added a commit to xael-fry/play that referenced this issue Dec 30, 2016
…ON by default.

[playframework#983] feat(DependenciesManager): add new option "nosync"
xael-fry added a commit to xael-fry/play that referenced this issue Jan 3, 2017
…ON by default.

[playframework#983] feat(DependenciesManager): add new option "nosync"
asolntsev added a commit that referenced this issue Jan 3, 2017
[#983] feat(DependenciesManager): sync option should be ON by default.
@xael-fry
Copy link
Member

Merged in 1.4.x with PR 1076.
Thanks

@daohodac
Copy link

I used to put my external jars in libs. Now, they are scrubbed when I run play dependencies Where should I put them now?

@xael-fry
Copy link
Member

@daohodac you can use --nosync to avoid removing the lib, on you can add your lib in dependencies.yml

@asolntsev
Copy link
Contributor Author

asolntsev commented Mar 13, 2017 via email

@daohodac
Copy link

How can I add the lib in dependencies.yml?

I assume that I have a folder in my play application, say "custom-deps" with several jars. How can I add this ref in the dependencies.yml?

thank's!

@asolntsev
Copy link
Contributor Author

@daohodac See https://github.com/codeborne/play-pdf/ for example.

You need to declate in dependencies.yml:

require:
    - local-jar -> flying-saucer-core-cbpatched latest.integration
    - local-jar -> flying-saucer-pdf-cbpatched latest.integration

repositories:
    - local-jars:
        type:       local
        artifact:   ${application.path}/jars/[module].jar
        contains:
            - local-jar -> *

@daohodac
Copy link

daohodac commented Mar 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants