Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to add player plugins that don't have a manifest in dnd library #47

Merged

Conversation

sandrews06
Copy link

@sandrews06 sandrews06 commented Feb 27, 2023

Context

Currently any player plugin added needs a manifest as well. This should only be for assets that need to be dragged and dropped.

What Changed

  • updated the config that is passed into the DragAndDropController so the manifest is passed in separately.
  • verified tests are still green.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 55.08% // Head: 55.10% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (26e84f7) compared to base (de99318).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 26e84f7 differs from pull request most recent head eb3e2a1. Consider uploading reports for the commit eb3e2a1 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/drag-and-drop      #47      +/-   ##
=========================================================
+ Coverage                  55.08%   55.10%   +0.01%     
=========================================================
  Files                         64       64              
  Lines                       3342     3343       +1     
  Branches                     985      986       +1     
=========================================================
+ Hits                        1841     1842       +1     
  Misses                      1176     1176              
  Partials                     325      325              
Impacted Files Coverage Δ
drag-and-drop/library/src/controller.tsx 50.00% <100.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KetanReddy KetanReddy merged commit 50b36f1 into player-ui:feature/drag-and-drop Feb 27, 2023
@sandrews06 sandrews06 deleted the feature/drag-and-drop branch February 27, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants