Add scale limit #38
Merged
Add scale limit #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Nov 15, 2023
| @@ -610,7 +610,9 @@ class ControlPanel extends Container { | |||
| const scaleInput = new NumericInput({ | |||
| class: 'control-element-expand', | |||
| precision: 2, | |||
| value: 1 | |||
| value: 1, | |||
| min: 0.01, | |||
There was a problem hiding this comment.
if they can scale up by 10k, why not down as well?
There was a problem hiding this comment.
I tried, but min must be a multiple of precision (which itself must be 2 for natural scaling).
mvaligursky
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit scale input to positive values.