Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to material chunks override functionality #7284

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Updates to material chunks override functionality #7284

merged 3 commits into from
Jan 16, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 16, 2025 •
edited
Loading

  • moved StandardMaterial.chunks API from StandardMaterial to Material class, to make it available for all material types
  • adjusted shader generators to use those in StandardMaterial, LitMaterial and ShaderMaterial, as those are based on chunks. All chunks, including material overrides are now available for the #include in the shader

@mvaligursky mvaligursky self-assigned this Jan 16, 2025
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jan 16, 2025
@mvaligursky mvaligursky requested a review from a team January 16, 2025 09:59
@mvaligursky mvaligursky merged commit dc9b072 into main Jan 16, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-material-chunks branch January 16, 2025 10:55
mvaligursky added a commit that referenced this pull request Jan 17, 2025
@mvaligursky
Updates to material chunks override functionality (#7284)
51caad7 
* Updates to material chunks override functionality

* lint

* cleanup

---------

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
@mvaligursky mvaligursky mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck