Scrollview remove entity reference #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Eastcott <willeastcott@gmail.com>
… into renderRootBoneOpt
|
@Maksims - could you please merge main to it and resolve the conflict |
Done. |
mvaligursky
approved these changes
Jan 6, 2025
I thought of some more unified way to handle entity setting, subscribe/unsubscribe mechanics also, but every case is so slightly different. This PR reduces overall amount of code in the Engine. I guess some refactoring is possible as a separate PR in the future, but that would require to refactor whole component's code. |
mvaligursky
pushed a commit
that referenced
this pull request
Jan 13, 2025
* optimize render component rootBone property * expose rootBone property * Update src/framework/components/render/component.js Co-authored-by: Will Eastcott <willeastcott@gmail.com> * use jsdo import * . * ButtonComponent remove EntityReference * remove reliance on component system global event lists * remove EntityReference from ScrollbarComponent * remove EntityReference, optimize ScrollVeiw and Scrollbar * lint --------- Co-authored-by: Will Eastcott <willeastcott@gmail.com> # Conflicts: # src/framework/components/scroll-view/component.js # src/framework/components/scroll-view/data.js # src/framework/components/scrollbar/component.js # src/framework/components/scrollbar/data.js # test/framework/utils/entity-reference.test.mjs
|
merged to v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #7194 and #7204 (and includes them already), merge them first please so diff is more concise.
This PR does not change API or behavior.
As mentioned in #7195 - EntityRefence need to go. This PR completes that, by removing a last dependency on it and also removing reliance on ComponentSystem's global event lists, which leads to exponentially higher costs of creating/removing related components (Element especially).
There is a significant performance improvement when creating/removing such components similar to other two PR's mentioned above. This also benefits ElementComponent's creation/removal performance, as every ScrollView and Scrollbar components were subscribing to ElementComponentSystem's global lists.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.