Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth prepass now works with multisampling on WebGPU #6945

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Depth prepass now works with multisampling on WebGPU #6945

merged 2 commits into from
Sep 11, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Sep 11, 2024 •
edited
Loading

Fixes #5714

When depth prepass is used in combination with multisampling on WebGPU:

  • the depth map for the render target needs to be in R32F format, so that we can resolve multi-sampled depth to it using shader

@mvaligursky mvaligursky self-assigned this Sep 11, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Sep 11, 2024
@mvaligursky mvaligursky requested a review from a team September 11, 2024 13:53
@mvaligursky mvaligursky merged commit af325c8 into main Sep 11, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-webgpu-msaa-prepass branch September 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebGPU MSAA render target with depth buffer fails
2 participants
@mvaligursky @slimbuck