fix touch event when target - is not an element #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Aug 14, 2024
willeastcott
approved these changes
Aug 15, 2024
|
Thank you, @Maksims! 🤗 |
mvaligursky
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix touch event when target - is not an element * PR comments * linter # Conflicts: # src/framework/input/element-input.js
|
I cherry-picked this change to main branch as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed in many games published on the web through Analytics Error Reporting that there is a case when touchmove event target - is not an element. It could be a
window.Which leads to an exception.
This PR fixes that and also re-uses the existing method within element-input.js as they are identical.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.