Gizmo scale fix v1 #6830
Merged
Gizmo scale fix v1 #6830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* disabled depth clipping and set start selection to be near clip instead of 1 * fixed gizmo scaling based on fov and aspect ratio * removed aspect ratio scaling * use distance instead of length for scale * removed unused property * removed redundant funciton for gizmo creation * refactor variable names * gizmo jsdoc and format cleanup * hoisted out guide angle color into constant * kept one pointDelta instance per class
willeastcott
approved these changes
Jul 18, 2024
slimbuck
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over fixed scaling from #6763