Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove opacityTint internal flag #6812

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove opacityTint internal flag #6812

merged 1 commit into from
Jul 12, 2024
+1 −20

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 12, 2024 •
edited
Loading

  • not a breaking change as this was internal flag only, used to optimize one uniform
  • this was causing a shader recompilation if alpha value change / blending mode changes, and so is removed.

@mvaligursky mvaligursky self-assigned this Jul 12, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jul 12, 2024
@mvaligursky mvaligursky requested a review from a team July 12, 2024 08:59
@mvaligursky mvaligursky mentioned this pull request Jul 12, 2024
Closed
22 tasks
@mvaligursky mvaligursky merged commit 4d251e8 into main Jul 12, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-remove-opacity-tint branch July 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck